slf4j and log4j updates #3085
Merged
slf4j and log4j updates #3085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerman
changed the title
ddanielr
previously approved these changes
Aug 7, 2025
jalphonso
reviewed
Aug 7, 2025
| fi | ||
|
|
||
| export HADOOP_OPTS=" ${HADOOP_INGEST_OPTS} -Dapp=bulkIngestMapFileLoader -DshutdownPort=$shutdownPort -Dfile.encoding=UTF8 -Duser.timezone=GMT" | ||
| export HADOOP_OPTS=" ${HADOOP_INGEST_OPTS} -Dlog4j.configuration=log4j-bulkloader.xml -Dapp=bulkIngestMapFileLoader -DshutdownPort=$shutdownPort -Dfile.encoding=UTF8 -Duser.timezone=GMT" |
Collaborator
There was a problem hiding this comment.
if I'm not mistaken I think this property changes to -Dlog4j2.configurationFile when using log4j2
Collaborator
Author
There was a problem hiding this comment.
i have a follow on PR that will do updates to the map file loaders. Ill include this change in that pr
Collaborator
There was a problem hiding this comment.
sounds good. you might also need slf4j-log4j12 for the v1 configuration to load. see if the application is actually logging or throwing errors in the console output during the logger initialization. alternatively, on the follow on PR just update to use the log4j2 configuration syntax preferably in yml
jalphonso
reviewed
Aug 7, 2025
warehouse/ingest-scripts/src/main/resources/bin/ingest/map-file-bulk-loader.sh
Show resolved
Hide resolved
update as per comment
jalphonso
approved these changes
Aug 7, 2025
ddanielr
approved these changes
Aug 7, 2025
apmoriarty
approved these changes
Aug 7, 2025
skyler-kv
pushed a commit
that referenced
this pull request
Aug 26, 2025
Breaking up the Bulkv2 PR to try to limit its scope and identify issues in smaller batches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up the Bulkv2 PR to try to limit its scope and identify issues in smaller batches