Skip to content

Conversation

@dws4
Copy link
Collaborator

@dws4 dws4 commented Aug 5, 2025

This PR does the following:

  1. Creates a filter icon near the search bar
  2. Can filter 'X' days prior based on a full search (by the search bar) by input and 'apply' button.
  3. Can reset and show all rows by clicking the 'show all rows' button by showing all rows.
  4. On loading, it will default to only 30 days prior.
  5. NEW 8/13/25: Fixed the Button Parse Bug (duplicate buttons appearing on same sections of data).

Note: Right now this has not been integration tested. Probably needs a rebase as well.

@dws4 dws4 self-assigned this Aug 5, 2025
foster33
foster33 previously approved these changes Aug 6, 2025
Copy link
Collaborator

@foster33 foster33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & LGTM

@dws4
Copy link
Collaborator Author

dws4 commented Aug 6, 2025

@foster33 Can you relook at it, I reset the button location and defaulted to 30 days prior upon request. Thanks

avgAGB
avgAGB previously approved these changes Aug 6, 2025
foster33
foster33 previously approved these changes Aug 6, 2025
@dws4 dws4 enabled auto-merge August 7, 2025 13:42
@dws4 dws4 dismissed stale reviews from foster33 and avgAGB via 3405ba8 August 7, 2025 15:36
@dws4 dws4 force-pushed the task/filterButton branch from 3405ba8 to 39e74bf Compare August 7, 2025 16:04
@dws4 dws4 force-pushed the task/filterButton branch from 39e74bf to 76cea7f Compare August 7, 2025 16:31
@dws4 dws4 requested review from avgAGB and foster33 August 8, 2025 14:25
dws4 and others added 2 commits August 13, 2025 13:42
…c/pages/DataDictionary.vue

Co-authored-by: foster33 <84727868+foster33@users.noreply.github.com>
@dws4 dws4 requested a review from foster33 August 13, 2025 18:56
jalphonso
jalphonso previously approved these changes Aug 13, 2025
@dws4 dws4 added this pull request to the merge queue Aug 14, 2025
Merged via the queue into integration with commit 3462115 Aug 14, 2025
6 checks passed
skyler-kv pushed a commit that referenced this pull request Aug 26, 2025
This PR does the following:
1. Creates a filter icon near the search bar
2. Can filter 'X' days prior based on a full search _(by the search
bar)_ by input and 'apply' button.
3. Can reset and show all rows by clicking the 'show all rows' button by
showing all rows.
4. On loading, it will default to only 30 days prior.
5. _NEW 8/13/25:_ Fixed the Button Parse Bug (duplicate buttons
appearing on same sections of data).

_Note: ~~Right now this has not been integration tested~~. ~~Probably
needs a rebase as well.~~_

---------

Co-authored-by: foster33 <84727868+foster33@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants