-
Notifications
You must be signed in to change notification settings - Fork 277
Filter Button to Retrieve Prior 'X' Amount of Days #3087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foster33
previously approved these changes
Aug 6, 2025
Collaborator
foster33
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested & LGTM
Collaborator
Author
|
@foster33 Can you relook at it, I reset the button location and defaulted to 30 days prior upon request. Thanks |
avgAGB
previously approved these changes
Aug 6, 2025
foster33
previously approved these changes
Aug 6, 2025
foster33
reviewed
Aug 13, 2025
microservices/services/dictionary/service/src/main/frontend/src/pages/DataDictionary.vue
Outdated
Show resolved
Hide resolved
…c/pages/DataDictionary.vue Co-authored-by: foster33 <84727868+foster33@users.noreply.github.com>
jalphonso
previously approved these changes
Aug 13, 2025
jalphonso
approved these changes
Aug 13, 2025
foster33
approved these changes
Aug 14, 2025
skyler-kv
pushed a commit
that referenced
this pull request
Aug 26, 2025
This PR does the following: 1. Creates a filter icon near the search bar 2. Can filter 'X' days prior based on a full search _(by the search bar)_ by input and 'apply' button. 3. Can reset and show all rows by clicking the 'show all rows' button by showing all rows. 4. On loading, it will default to only 30 days prior. 5. _NEW 8/13/25:_ Fixed the Button Parse Bug (duplicate buttons appearing on same sections of data). _Note: ~~Right now this has not been integration tested~~. ~~Probably needs a rebase as well.~~_ --------- Co-authored-by: foster33 <84727868+foster33@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Note:
Right now this has not been integration tested.Probably needs a rebase as well.