Remove non-public Accumulo API usage from ScannerBaseDelegate #3331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor to track iterator names locally instead of introspecting the delegate via non-public ScannerOptions/IterInfo APIs. This eliminates dependencies on: - org.apache.accumulo.core.clientImpl.ScannerOptions - org.apache.accumulo.core.dataImpl.thrift.IterInfo - com.google.common.collect.Lists Changes: - Add systemIteratorNames and userIteratorNames Sets to track iterators - Update add/remove methods to maintain the local tracking sets - Simplify clearScanIterators() to iterate over tracked names - Remove ScannerOptionsHelper inner class
lbschanno
reviewed
Jan 21, 2026
|
|
||
| @Override | ||
| public void clearScanIterators() { | ||
| if (delegate instanceof ScannerOptions) { |
Collaborator
There was a problem hiding this comment.
I'm not 100% sure it's safe to remove this check until we know we're not using or creating instances of ScannerOptions anywhere (and know that accumulo isn't creating any instances of them anywhere). There was some initial work done to replace our usage of ScannerOptions with datawave.query.tables.SessionOptions, so that could be an avenue for replacement here instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ScannerOptions,IterInfoScannerOptionsHelperinner classclearScanIterators()implementationFixes #3334
Part of #2443