Add internal cleanup_include_files config#28
Merged
gwleuverink merged 7 commits intomainfrom Oct 21, 2025
Merged
Conversation
PeteBishwhip
requested changes
Oct 21, 2025
PeteBishwhip
approved these changes
Oct 21, 2025
Member
PeteBishwhip
left a comment
PeteBishwhip
left a comment
There was a problem hiding this comment.
Happy to add my checkmark to this as-is, but with two additional improvements which I think are valuable but certainly not blockers.
Collaborator
Author
|
Thanks Pete! I'll merge this in so I can make a draft for Simon to review 👍 |
Member
I've added the branch ruleset, but we never enforced tests to pass as part of PR approval because of their flakiness. If we can stabilise them, I'd say we can enforce that they pass and block PRs from being merged if they don't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a more resilient approach to the hardcoded copy introduced in #26
I've added a new config
cleanup_include_filesthat forcibly adds files and folders by glob pattern even if a parent folder was included incleanup_exclude_files.This also fixes some failing tests. I didn't see those tests fail, likely because they are somehow not enforced to run in this repo? @simonhamp can you check that?