Fix narive:run use correct binary on Intel macs#32
Merged
gwleuverink merged 2 commits intomainfrom Oct 24, 2025
Merged
Conversation
instead of old x86 binary. This was a naming misnomer. The binary is no longer updated. Also updated the naming of the npm build scripts & command arguments
Collaborator
Author
|
This might be a good time to remove those old binaries. We can slim down the |
SRWieZ
approved these changes
Oct 24, 2025
simonhamp
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
A while back we corrected a naming misnomer of the mac binaries.
While this all worked while building it looks like folks using
native:runon a intel mac were still using the outdatedx86binary. This PR addresses that.Also updated the naming of the npm build scripts & command arguments so everything is named consistently across the board.