Add method to change notification sound#33
Conversation
simonhamp
left a comment
simonhamp
left a comment
There was a problem hiding this comment.
You'll need to bring the changes from NativePHP/electron#257 into this repository now, as they've been combined
|
I have moved the changes made in NativePHP/electron#257 to the electron folder in this repository, i have also tested my changes in a demo app and they seem to work for me. |
|
@gwleuverink what do you think we should do with this |
resources/electron/electron-plugin/src/server/api/notification.ts
Outdated
Show resolved
Hide resolved
resources/electron/electron-plugin/src/server/api/notification.ts
Outdated
Show resolved
Hide resolved
resources/electron/electron-plugin/src/server/api/notification.ts
Outdated
Show resolved
Hide resolved
resources/electron/electron-plugin/src/server/api/notification.ts
Outdated
Show resolved
Hide resolved
Can we merge main back to this branch & run |
gwleuverink
left a comment
gwleuverink
left a comment
There was a problem hiding this comment.
This is a great addition 👍🏻 Thanks @Jianbe-03! Could clarify a few questions in the comments?
resources/electron/electron-plugin/src/server/api/notification.ts
Outdated
Show resolved
Hide resolved
resources/electron/electron-plugin/src/server/api/notification.ts
Outdated
Show resolved
Hide resolved
resources/electron/electron-plugin/src/server/api/notification.ts
Outdated
Show resolved
Hide resolved
…orm specific afplay command since playSoundLib already does this
|
Every requested change should be implemented now, can this be verified so the branch can be merged? @simonhamp @gwleuverink |
gwleuverink
left a comment
gwleuverink
left a comment
There was a problem hiding this comment.
This is great! Looking at the entire PR now I have one more recommendation. Are you up to adding that?
This might be the direction you were going before using that custom event. I def think it's helpful to show the dev why it's erroring
gwleuverink
left a comment
gwleuverink
left a comment
There was a problem hiding this comment.
Looks good! Thanks @Jianbe-03 !
|
codestyle workflow is failing (due to outside branch) all is green when running locally. will skip that check |
3 participants
This pull request adds support for sound notifications and silent mode to the
Notificationclass. These changes allow notifications to specify a custom sound and to be marked as silent, providing more flexibility in how notifications are delivered and displayed.New notification features:
soundandsilentproperties to theNotificationclass, allowing notifications to specify a sound and whether they should be silent.sound()andsilent()methods in theNotificationclass to set these new properties.show()method to includesoundandsilentin the notification payload.This addition does require an update to the electron repository, i made the changes for this pull request in here: NativePHP/electron#257