feat(legacy): 💄 add recommendation for our AI course#478
Open
BleedingDev wants to merge 5 commits intomasterfrom
Open
feat(legacy): 💄 add recommendation for our AI course#478BleedingDev wants to merge 5 commits intomasterfrom
BleedingDev wants to merge 5 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WIP: Needs changing main video
BleedingDev
changed the title
BleedingDev
changed the title
xhemalov
approved these changes
Oct 31, 2024
BleedingDev
force-pushed
the
master
branch
10 times, most recently
from
93e43db to
57ca4f9
Compare
BleedingDev
force-pushed
the
master
branch
3 times, most recently
from
bc26872 to
e44eaff
Compare
BleedingDev
force-pushed
the
master
branch
10 times, most recently
from
5d4477b to
6a372f4
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- apps/legacy_nmit/package.json: Language not supported
- apps/legacy_nmit/pages/_document.tsx: Language not supported
- apps/legacy_nmit/pages/chapter/[post].tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)
apps/legacy_nmit/pages/dashboard.tsx:49
- Ensure that the new behavior introduced by the
MissingBannercomponent is covered by tests.
<MissingBanner />
Owner
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+59
to
+61
| <p className="text-gray-600"> | ||
| <iframe className='w-full aspect-video' src="https://www.youtube.com/embed/ZXB3XTZRtdk" title="Pozvánka na AI kurz" frameBorder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerPolicy="strict-origin-when-cross-origin" allowFullScreen /> | ||
| </p> |
There was a problem hiding this comment.
The <p> element should not contain an <iframe> as its child. According to HTML semantics, <p> elements should only contain phrasing content (inline elements), not embedded content like iframes.
Remove the <p> wrapper:
<div className="mt-4">
<iframe className='w-full aspect-video' src="https://www.youtube.com/embed/ZXB3XTZRtdk" title="Pozvánka na AI kurz" frameBorder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerPolicy="strict-origin-when-cross-origin" allowFullScreen />
</div>
Suggested change
| <p className="text-gray-600"> | |
| <iframe className='w-full aspect-video' src="https://www.youtube.com/embed/ZXB3XTZRtdk" title="Pozvánka na AI kurz" frameBorder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerPolicy="strict-origin-when-cross-origin" allowFullScreen /> | |
| </p> | |
| <iframe className='w-full aspect-video' src="https://www.youtube.com/embed/ZXB3XTZRtdk" title="Pozvánka na AI kurz" frameBorder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerPolicy="strict-origin-when-cross-origin" allowFullScreen /> |
| </Dialog.Close> | ||
| <Dialog.Title className="text-lg font-semibold"> | ||
| AI Kurz | ||
| </Dialog.Title> |
There was a problem hiding this comment.
Missing Dialog.Description for accessibility. Radix UI Dialog components should include a description for screen readers to properly announce the modal content.
Add a description after the title:
<Dialog.Title className="text-lg font-semibold">
AI Kurz
</Dialog.Title>
<Dialog.Description className="sr-only">
Podívejte se na naše video o AI kurzu a přihlaste se
</Dialog.Description>If you want to keep the description visible, remove sr-only class.
Suggested change
| </Dialog.Title> | |
| </Dialog.Title> | |
| <Dialog.Description className="sr-only"> | |
| Podívejte se na naše video o AI kurzu a přihlaste se | |
| </Dialog.Description> |
Comment on lines
+24
to
+28
| useEffect(() => { | ||
| if (router.asPath.startsWith("/kurz-ai")) { | ||
| setTimeout(handleClose, 500) | ||
| } | ||
| }, [router.asPath]) |
There was a problem hiding this comment.
This useEffect has multiple issues:
- Missing cleanup for
setTimeout- can cause memory leaks and unexpected behavior - Missing
handleClosein dependency array - can lead to stale closures
Fix both issues:
useEffect(() => {
const cleanup = () => {
document.cookie = `${MODAL_COOKIE_KEY}=true; path=/; max-age=${60 * 60 * 24 * 365}; SameSite=Lax`
setIsOpen(false)
}
if (router.asPath.startsWith("/kurz-ai")) {
const timeoutId = setTimeout(cleanup, 500)
return () => clearTimeout(timeoutId)
}
}, [router.asPath])Alternatively, wrap handleClose with useCallback and include it in the dependency array.
|
|
||
| <div className="mt-4"> | ||
| <p className="text-gray-600"> | ||
| <iframe className='w-full aspect-video' src="https://www.youtube.com/embed/ZXB3XTZRtdk" title="Pozvánka na AI kurz" frameBorder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerPolicy="strict-origin-when-cross-origin" allowFullScreen /> |
There was a problem hiding this comment.
The frameBorder attribute is deprecated in HTML5. Use the CSS border property instead or remove this attribute as modern browsers default to no border for iframes.
Replace frameBorder="0" with inline style or CSS class:
<iframe className='w-full aspect-video border-0' ... />
Suggested change
| <iframe className='w-full aspect-video' src="https://www.youtube.com/embed/ZXB3XTZRtdk" title="Pozvánka na AI kurz" frameBorder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerPolicy="strict-origin-when-cross-origin" allowFullScreen /> | |
| <iframe className='w-full aspect-video border-0' src="https://www.youtube.com/embed/ZXB3XTZRtdk" title="Pozvánka na AI kurz" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerPolicy="strict-origin-when-cross-origin" allowFullScreen /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(legacy): 💄 add recommendation for our AI course
WIP: Needs changing main video
This reverts banner feature commits.