Open
Conversation
Owner
|
Hey, thanks for this PR sorry I didn't find the time to take a look at it and test it. I'll reopen it because I'm happy to integrate it. |
Closed
NautiluX
reviewed
Apr 20, 2021
Owner
NautiluX
left a comment
NautiluX
left a comment
There was a problem hiding this comment.
Still want to have a closer look at the code. I'm fine if you have to check out and compile that qt lib to build binaries for slide, but if one just wants to use it we should at least provide a simple way to use it without until it's an official part of the qt lib. WDYT?
Comment on lines
+83
to
+94
| Build Qt plugin for *.heic (Iphone) files | ||
|
|
||
| ``` | ||
| git clone https://github.com/jakar/qt-heif-image-plugin.git | ||
| cd qt-heif-image-plugin | ||
| mkdir -p build | ||
| cd build | ||
| cmake .. | ||
| make | ||
| sudo make install | ||
| ``` | ||
|
|
Owner
There was a problem hiding this comment.
Is this necessary only to compile from source or as well to just run it? Can I use slide without heic support if I leave this out?
|
|
||
| ## if *.heic support wanted | ||
| * libheif | ||
| * qt-heif-image-plugin (alas is not a part of Qt jet, have to be compiled, see instuctions below) |
Owner
There was a problem hiding this comment.
Suggested change
| * qt-heif-image-plugin (alas is not a part of Qt jet, have to be compiled, see instuctions below) | |
| * qt-heif-image-plugin (alas is not a part of Qt yet, have to be compiled, see instuctions below) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My wife has Iphone and suddenly I was confronted with *.heic files my Raspi/Slide didn't know what to do with. I looked around, made some assumptions and here I'm sharing the results: tested (at the moment) on raspi 4 buster support for *.heic format image for Slide.
Because getting the exif data from heic images was a bit tricky I made a change on top of my proposed ExifHelper - which helped :).
Take care