#141 Add net 6 to enable removal of STJ#142
Open
thompson-tomo wants to merge 3 commits intoNetTopologySuite:developfrom
Open
#141 Add net 6 to enable removal of STJ#142thompson-tomo wants to merge 3 commits intoNetTopologySuite:developfrom
thompson-tomo wants to merge 3 commits intoNetTopologySuite:developfrom
Conversation
Member
|
📄 Maybe, but this one isn't as much of a no-brainer as adding a Pros:
Cons:
On balance, I am slightly opposed to this, but that second "con" hides a bit of a "pro" within it that makes me not want to try to shut this down entirely. That "pro": if we can get through the initial inertia of setting up appropriate automated testing that will cover all the conditional-compilation branches that we choose to add, then we can write code that will work better on newer platforms without completely leaving .NET Framework in the dust. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in Net 6 so that STJ can be provided by the framework
Closes #141