Fix: asyncBulkGet decoding of hashed and unhashed keys together in one request#181
Merged
Fix: asyncBulkGet decoding of hashed and unhashed keys together in one request#181
Conversation
Sunjeet
changed the title
shy-1234
reviewed
Feb 4, 2026
evcache-core/src/main/java/net/spy/memcached/EVCacheMemcachedClient.java
Outdated
Show resolved
Hide resolved
shy-1234
reviewed
Feb 4, 2026
| try { | ||
| obj = tcService.decode(envelopeTranscoder, new CachedData(flags, data, envelopeTranscoder.getMaxSize())).get(); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException("Failed to decode key " + k + " using evCacheValueTranscoder", e); |
Contributor
There was a problem hiding this comment.
"using envelopeTranscoder" to be more generic? (and maybe the transcoder class name?)
shy-1234
reviewed
Feb 4, 2026
evcache-core/src/main/java/net/spy/memcached/EVCacheMemcachedClient.java
Show resolved
Hide resolved
shy-1234
approved these changes
Feb 5, 2026
Sunjeet
force-pushed
the
sunjeets/fix/asyncbulkget
branch
from
2679e34 to
d90819e
Compare
Sunjeet
force-pushed
the
sunjeets/fix/asyncbulkget
branch
from
d90819e to
3f339e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: if any hashed keys were present in asyncbulkget,
evCacheTranscoderwould be applied to all results, and where the app specified a custom transcoder, the first application usingevCacheTranscoderon un-hashed results would fallback to decoding the value as a String, and returning that String as is to the app (vs. invoking the custom transcoder on the underlying bytes).The approach taken is to pass knowledge of hashed vs. unhashed keys and the 2 transcoders down into EVCacheClient::getAsyncBulk and onwards to EVCacheMemcachedClient::asyncGetBulk so that its gotData listener can do a one-step or two-step decode per key.