Fixing issues in deployment, including #666, #667 and #668#670
Open
Glamdring wants to merge 5 commits intoNetflix:3.11from
Open
Fixing issues in deployment, including #666, #667 and #668#670Glamdring wants to merge 5 commits intoNetflix:3.11from
Glamdring wants to merge 5 commits intoNetflix:3.11from
Conversation
Glamdring
force-pushed
the
production-fixes
branch
from
4f333d3 to
588e54b
Compare
| public SDBInstanceData(ICredential provider, IConfiguration configuration) { | ||
| this.provider = provider; | ||
| this.configuration = configuration; | ||
| String configuredDomain = System.getProperty("priam.sdb.instanceidentity.domain"); |
Contributor
There was a problem hiding this comment.
Can we wrap this configuration into IConfiguration?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.