allow multiple meta blocks and merge them if present#424
Open
doits wants to merge 1 commit intoNetflix:devfrom
Open
allow multiple meta blocks and merge them if present#424doits wants to merge 1 commit intoNetflix:devfrom
doits wants to merge 1 commit intoNetflix:devfrom
Conversation
Useful for includes and inheritance:
```rb
module SomeModule
extend ActiveSupport::Concern
included do
meta do
{
module_meta: true
}
end
end
end
class UserSerializer
include FastJsonapi::ObjectSerializer
include SomeModule
meta do
{
user_meta: true
}
end
end
class EmployeeSerializer < UserSerializer
meta do
{
employee_meta: true
}
end
end
EmployeeSerializer.new(employee).serializable_hash
{
data: {
[...]
meta: {
module_meta: true,
user_meta: true,
employee_meta: true
}
}
}
```
Author
|
One thing to discuss is whether Otherwise I think this change makes composing serializers out of different modules and/or inheritance much more simpler, because each module or class can have meta blocks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for includes and inheritance: