Better crypto-bigint Monty multiplication#28
Merged
frozenspider merged 17 commits intomainfrom Feb 5, 2026
Merged
Conversation
frozenspider
changed the title
frozenspider
requested review from
NiDimi,
cupicmarko and
maksimryndin
as code owners
ElijahVlasov
reviewed
Feb 5, 2026
Collaborator
Author
|
@ElijahVlasov, I've added some more delegations to the new optimized multiplication, could you please take another look? |
ElijahVlasov
reviewed
Feb 5, 2026
ElijahVlasov
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a better algorithm for limbed integer multiplication. Our benches show consistent 10-40% increase in speed for both Monty and ConstMonty, most prominent improvement being
product.This is despite the unfortunately fact that due to RustCrypto/crypto-bigint#1186 we have to recompute
mod_neg_invas it's not accessible in the parameters struct.Note: This approach, when applied to
BoxedMontyField, worsens runtime by ~10-30% due to compile-time optimizations not being applicable to dynamically sized slices