-
Notifications
You must be signed in to change notification settings - Fork 17
[DRAFT] Convert EELS tests to gas-benchmarks format on a stateful network #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[DRAFT] Convert EELS tests to gas-benchmarks format on a stateful network #95
Conversation
…un stateful tests instead of bench tests
| f"--rpc-endpoint={tests_rpc}", | ||
| f"--gas-benchmark-values={args.gas_benchmark_values}", | ||
| "--eoa-fund-amount-default", "3100000000000000000", | ||
| #"--eoa-fund-amount-default", "3100000000000000000", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This flag seems to be removed from EELS (or it is not available in execute remote). Might also be renamed.
| #"--eoa-fund-amount-default", "3100000000000000000", | ||
| "--tx-wait-timeout", "300", | ||
| "--eoa-start", "103835740027347086785932208981225044632444623980288738833340492242305523519088", | ||
| #"--eoa-start", str(int(args.rpc_seed_key, 16)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OG has hardcoded eoa start, so need to figure out why this is, and if we even have to provide this flag (should it be the same as the rpc pkey? What is the difference)?
| args.test_path, | ||
| "--", | ||
| "-m", "benchmark", "-n", "1", | ||
| "-m", "stateful", "-n", "1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stateful makes bloatnet tests run.
benchmark makes the compute tests run. (Not sure if stateful also runs compute, did not yet check)
|
EELS commit was here: 3ac8ce8865e2239a0d5d576091770573accc04c8 |
Progress dump to run stateful tests locally.
Command ran inside
gas-benchmarks:python3 eest_stateful_generator.py --fork Osaka --rpc-seed-key PKEY --rpc-address ADDRESS_ASSOCIATED_WITH_PKEY --test-path tests/benchmark/statefulThe
execution-datafolder insidegas-benchmarksshould look like (this is and MUST be a Nethermind snapshot, because we need to use the "hacked" Neth version to fill tests)I had to add this
InitDbPathotherwise Nethermind does not "grab" the snapshot correctly.Do not merge 😄 👍