fix: warnning dll-attribute-on-redeclaration on windows#1040
Open
mengshengwu wants to merge 1 commit intomainfrom
Open
fix: warnning dll-attribute-on-redeclaration on windows#1040mengshengwu wants to merge 1 commit intomainfrom
mengshengwu wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Windows-specific compiler warning (dll-attribute-on-redeclaration) related to the C declaration of the Go-exported go_log_wrap callback in the Nexa SDK cgo bridge.
Changes:
- Add a Windows-only
__declspec(dllexport)declaration forgo_log_wrapto match the expected DLL export attribute and avoid redeclaration warnings. - Keep the existing
externdeclaration for non-Windows platforms.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.