Conversation
- Add ChacIcons icon system with separate files for each icon - BackIcon: Navigation back arrow - AlertIcon: Warning/alert icon for dialogs - CheckSelectedIcon: Selected checkbox (purple) - CheckUnselectedIcon: Unselected checkbox (translucent gray) - Apply design system throughout gallery screen - Use ChacColors for all color values - Use ChacTextStyles for all text styling - Apply black background (ChacColors.Background) - Improve gallery UI components - Show checkboxes in both selected/unselected states - Improve selection counter format with proper spacing - Replace OutlinedButton with Box for select all button - Update exit dialog with black background - Add new color tokens (Etc, Black40) - Add string resources for unselect all and slash separator Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
KimSungBeen
approved these changes
Feb 4, 2026
Collaborator
KimSungBeen
left a comment
KimSungBeen
left a comment
There was a problem hiding this comment.
일단 눈에 보이는 것들만 코멘트 남겼는데
지금 디자인이 계속 바뀌고 있으니까, 형이 판단해서 무시하고 먼저 병합해도 괜찮을 것 같아!
LGTM~ 😊
feature/album/src/main/java/com/chac/feature/album/gallery/GalleryScreen.kt
Outdated
Show resolved
Hide resolved
feature/album/src/main/java/com/chac/feature/album/gallery/GalleryScreen.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+346
to
+348
| style = ChacTextStyles.Body, | ||
| color = ChacColors.Text03, | ||
| textAlign = TextAlign.Center |
Collaborator
There was a problem hiding this comment.
디자인에서 다이얼로그 본문이랑 버튼 간격 30.dp 라서
이 Text에 10.dp bottom 패딩 추가 하거나 Text아래 Spacer 추가되어야 할듯!
feature/album/src/main/java/com/chac/feature/album/gallery/GalleryScreen.kt
Outdated
Show resolved
Hide resolved
feature/album/src/main/java/com/chac/feature/album/gallery/GalleryScreen.kt
Outdated
Show resolved
Hide resolved
feature/album/src/main/java/com/chac/feature/album/gallery/GalleryScreen.kt
Outdated
Show resolved
Hide resolved
feature/album/src/main/java/com/chac/feature/album/gallery/GalleryScreen.kt
Outdated
Show resolved
Hide resolved
feature/album/src/main/java/com/chac/feature/album/gallery/GalleryScreen.kt
Show resolved
Hide resolved
…leryScreen.kt Co-authored-by: KimSungBeen <s_been@kakao.com>
…leryScreen.kt Co-authored-by: KimSungBeen <s_been@kakao.com>
…leryScreen.kt Co-authored-by: KimSungBeen <s_been@kakao.com>
…leryScreen.kt Co-authored-by: KimSungBeen <s_been@kakao.com>
…leryScreen.kt Co-authored-by: KimSungBeen <s_been@kakao.com>
…leryScreen.kt Co-authored-by: KimSungBeen <s_been@kakao.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
갤러리 화면 디자인을 스크린샷과 동일하게 구현하고, 커스텀 아이콘 시스템을 추가했습니다.
Changes
🎨 Icon System
BackIcon.kt: 뒤로가기 화살표 아이콘AlertIcon.kt: 경고/알림 느낌표 아이콘CheckSelectedIcon.kt: 선택된 체크박스 (보라색 배경)CheckUnselectedIcon.kt: 선택 안 된 체크박스 (반투명 회색)🖼️ Gallery Screen
디자인 시스템 적용
ChacColors로 변경ChacTextStyles로 변경ChacColors.Background)으로 변경UI 개선
0 / 53- 공백 포함)OutlinedButton에서Box로 변경🎨 Design System
gallery_unselect_all,gallery_slash리소스 추가Screenshots
Issue #39의 스크린샷과 동일하게 구현됨
Test plan
Resolves #39
🤖 Generated with Claude Code