implemented in-app update functionality#105
Conversation
Signed-off-by: AdiAr11 <aditya2000arora@gmail.com>
Ni3verma
left a comment
Ni3verma
left a comment
There was a problem hiding this comment.
@AdiAr11 I have added some comments.. most of them are related to reverting some changes.
I will read the documentation and then review app update related code.
one more suggestion, please add Timber info logs wherever you think it will be useful.
I will make the required changes. Also, I haven't actually used Timber logs before, I'm still learning Android Development, sorry. I will look it up. |
This reverts commit a0dba18 Signed-off-by: AdiAr11 <aditya2000arora@gmail.com>
Signed-off-by: AdiAr11 <aditya2000arora@gmail.com>
Signed-off-by: AdiAr11 <aditya2000arora@gmail.com>
Ni3verma
left a comment
Ni3verma
left a comment
There was a problem hiding this comment.
have added some comments for code placement.
also are you not running git hooks? step 7 in contibuting.md file?
your PR is failing with detekt,ktlint errors.
I'm sorry but there was no check box for git hooks. I'll check and make the required changes |
Signed-off-by: AdiAr11 <aditya2000arora@gmail.com>
# Conflicts: # app/src/main/res/values/strings.xml
Signed-off-by: AdiAr11 <aditya2000arora@gmail.com>
Ni3verma
left a comment
Ni3verma
left a comment
There was a problem hiding this comment.
while merging strings.xml, you accidently removed incoming changes
you had to merge : basically incoming changes + your changes
oh, sorry..I'll correct this mistake |
Signed-off-by: AdiAr11 <aditya2000arora@gmail.com>
|
Please let me know if something else needs to be changed |
| } | ||
|
|
||
| private fun snackbarForCompleteUpdate() { | ||
| Snackbar.make(findViewById(R.id.content), "App update has been downloaded", Snackbar.LENGTH_INDEFINITE) |
Ni3verma
left a comment
Ni3verma
left a comment
There was a problem hiding this comment.
one small string hardcode issue
and currently you are always showing update dialog whenever it is available... like we discussed, keep some buffer... maybe ask after every 2/5 days.
|
could you walk me through a little on how to go about asking for updating after 2/5 days? |
2 participants
Signed-off-by: AdiAr11 aditya2000arora@gmail.com
Description
Added in-app update feature
Impacted Issue number
Closes #85
Type of change
Enhancement
Code quality checklist
Just put an x in the [] where applicable.
gradlew lintand found no new error related to my code in the report.