-
Notifications
You must be signed in to change notification settings - Fork 2
Update Pull Request Template #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8bf1e03
Update pull_request_template.md
saketharsh 7d332c7
Update pull_request_template.md
saketharsh 0ea5b11
Update pull_request_template.md
saketharsh 0e32dca
Update pull_request_template.md
saketharsh d9c5a21
Update pull_request_template.md
saketharsh 21ca83a
Update .github/pull_request_template.md
saketharsh faecfc9
Update .github/pull_request_template.md
saketharsh dd08728
Update .github/pull_request_template.md
saketharsh 59aa17f
Update .github/pull_request_template.md
saketharsh 2e42827
Update pull_request_template.md
saketharsh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,16 @@ | ||
| # Description | ||
| Include a descripton of what this change does. | ||
|
|
||
| Please include a summary of the changes and the related issue. | ||
| Please also include relevant motivation and context. Mention dependency if there are. | ||
| Type - Bug/Feature/Improvements | ||
|
|
||
| Attach PR link to Asana | ||
saketharsh marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| Fixes # (issue) | ||
| Design Doc Link - | ||
|
|
||
| ## Type of change | ||
| ## Tests | ||
| - [ ] Existing tests cover this scenario too | ||
saketharsh marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| Please delete options that are not relevant. | ||
| - [ ] New tests added for this change | ||
saketharsh marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| Mention steps to reproduce the fix or run tests for the changes. | ||
|
|
||
| - [ ] Improvements | ||
| - [ ] Bug fix (non-breaking change which fixes an issue) | ||
| - [ ] New feature (non-breaking change which adds functionality) | ||
| - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
|
|
||
| ## Changes proposed in this PR | ||
|
|
||
| ## How Has This Been Tested? | ||
|
|
||
| ## Checklist: | ||
|
|
||
| - [ ] My code follows the style guidelines of this project | ||
| - [ ] I have performed a self-review of my code | ||
| - [ ] I have commented my code, particularly in hard-to-understand areas | ||
| - [ ] I have made corresponding changes to the documentation | ||
| - [ ] I have added tests that prove my fix is effective or that my feature works | ||
| - [ ] New and existing unit tests pass locally with my changes | ||
| - [ ] Any dependent changes have been merged and published in downstream modules | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.