hydra-eval-jobs: don't use restrict-eval for Flakes#1257
Open
lheckemann wants to merge 1 commit intoNixOS:masterfrom
Open
hydra-eval-jobs: don't use restrict-eval for Flakes#1257lheckemann wants to merge 1 commit intoNixOS:masterfrom
lheckemann wants to merge 1 commit intoNixOS:masterfrom
Conversation
Member
Author
|
Draft, because:
|
Pure evaluation should cover all the uses for restrict-eval, and restrict-eval currently breaks accessing Git inputs on Flakes[1]. [1]: NixOS/nix#7098
148a086 to
9370b0e
Compare
Member
Author
|
I think it's OK to do this. People disabling pure evaluation presumably have a good reason to do so. |
Member
|
This does open up access to |
Member
Author
|
In that case, I guess fixing NixOS/nix#7098 in Nix is the right approach to solving this problem. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure evaluation should cover all the uses for restrict-eval, and restrict-eval currently breaks accessing Git inputs on Flakes1.