Skip to content

Conversation

@franzhusch
Copy link

I wanted to make this change to emphasize the difference between the builtin fetchers and the nixpkgs fetchers.

Copy link

@hsjobeki hsjobeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a lgtm improvement.
However we should be more concrete.

  • "more optimized evaluation" -> optimized how? For what use case? This is too vague.
  • "differ in some aspects" -> which aspects? Same problem.

This should be more concrete.

Suggestion: highlight the most important difference. Paused eval i assume.
For the rest place a reference to the manual.

hsjobeki

This comment was marked as outdated.

@franzhusch
Copy link
Author

franzhusch commented Dec 29, 2025

Thanks for the feedback @hsjobeki. I have chosen to highlight the additional hash argument in the nixpkgs fetchers. That will also make them recognizable and is probably the most apparent difference for anyone not too deep into the details. Feel free to give me additional feedback if you think something could be better :)

Co-authored-by: Johannes Kirschbauer <hsjobeki+github@gmail.com>
@franzhusch
Copy link
Author

Your suggestions read much better @hsjobeki . I will take the tips and try to write better next time.

Co-authored-by: Valentin Gagarin <valentin@gagarin.work>
The Nixpkgs manual on [Fetchers][nixpkgs-fetchers] lists numerous additional library functions to fetch files over the network.
Nixpkgs provides its own fetcher functions to reduce the time needed for evaluating Nixpkgs. The Nixpkgs fetchers are not directly interchangeable with builtin fetchers; for example, the Nixpkgs fetchers require a hash argument.

::::{note}
Copy link

@hsjobeki hsjobeki Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you unify this into only one :::{note} block?

Suggested change
::::{note}

Also the following three sentences should be trimmed down to only contain essential and required information.
Instead of repeating one of them in a nested :::note

  • Nixpkgs provides its own fetcher functions to reduce the time needed for evaluating Nixpkgs. -> Nixpkgs provides its own fetcher functions to reduce the time needed for evaluation.
  • The Nixpkgs fetchers are not directly interchangeable with builtin fetchers; for example, the Nixpkgs fetchers require a hash argument. -> They are not directly interchangeable with builtins fetchers
  • Nixpkgs provides its own fetcher functions with important differences from the builtin fetchers: -> Important differences:

for example, the Nixpkgs fetchers require a hash argument. can be left out, because you explicitly state that later in the bullet list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants