Skip to content

startDaemon(): Detect if the daemon crashes before creating the socket (backport #12499)#12507

Closed
mergify[bot] wants to merge 1 commit into2.18-maintenancefrom
mergify/bp/2.18-maintenance/pr-12499
Closed

startDaemon(): Detect if the daemon crashes before creating the socket (backport #12499)#12507
mergify[bot] wants to merge 1 commit into2.18-maintenancefrom
mergify/bp/2.18-maintenance/pr-12499

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 18, 2025

Motivation

This avoids timeouts like those seen in https://github.com/NixOS/nix/actions/runs/13376958708/job/37358120348?pr=6962.

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.


This is an automatic backport of pull request #12499 done by [Mergify](https://mergify.com).

@mergify mergify bot added the automatic backport This PR is a backport produced by automation (does not trigger backporting) label Feb 18, 2025
@mergify mergify bot requested a review from edolstra as a code owner February 18, 2025 16:38
@mergify
Copy link
Contributor Author

mergify bot commented Feb 18, 2025

Cherry-pick of 11c42cb has failed:

On branch mergify/bp/2.18-maintenance/pr-12499
Your branch is up to date with 'origin/2.18-maintenance'.

You are currently cherry-picking commit 11c42cb2e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   tests/functional/common/functions.sh

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Feb 18, 2025
@Ericson2314 Ericson2314 force-pushed the mergify/bp/2.18-maintenance/pr-12499 branch from be0bc5f to 4d13688 Compare February 18, 2025 16:44
@Ericson2314
Copy link
Member

@edolstra I am surprised this backport is failing

@edolstra
Copy link
Member

Let's close this, not really important enough to backport.

@edolstra edolstra closed this Feb 24, 2025
auto-merge was automatically disabled February 24, 2025 13:52

Pull request was closed

@xokdvium xokdvium deleted the mergify/bp/2.18-maintenance/pr-12499 branch October 7, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automatic backport This PR is a backport produced by automation (does not trigger backporting) conflicts merge-queue with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments