startDaemon(): Detect if the daemon crashes before creating the socket (backport #12499)#12507
Closed
mergify[bot] wants to merge 1 commit into2.18-maintenancefrom
Closed
startDaemon(): Detect if the daemon crashes before creating the socket (backport #12499)#12507mergify[bot] wants to merge 1 commit into2.18-maintenancefrom
mergify[bot] wants to merge 1 commit into2.18-maintenancefrom
Conversation
Contributor
Author
|
Cherry-pick of 11c42cb has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This avoids timeouts like those seen in https://github.com/NixOS/nix/actions/runs/13376958708/job/37358120348?pr=6962. (cherry picked from commit 11c42cb)
be0bc5f to
4d13688
Compare
Ericson2314
approved these changes
Feb 18, 2025
Member
|
@edolstra I am surprised this backport is failing |
Member
|
Let's close this, not really important enough to backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This avoids timeouts like those seen in https://github.com/NixOS/nix/actions/runs/13376958708/job/37358120348?pr=6962.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
This is an automatic backport of pull request #12499 done by [Mergify](https://mergify.com).