More IO portability cleanups#15038
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 4, 2026
Merged
Conversation
github-actions
bot
added
new-cli
|
🎉 All dependencies have been resolved ! |
Ericson2314
force-pushed
the
drainfd-improvements
branch
from
94bd686 to
2c7bd95
Compare
artemist
force-pushed
the
drainfd-improvements
branch
from
e740188 to
ef254ca
Compare
- options structs for `drainFD` (both versions) - portable `read` wrapper - portable `GetFileSize` wrapper - dedup `readFile` and `drainFD` using the above - Use `drainFD` in `PosixSourceAccessor`, avoiding manual IO - Remove `fromDescriptorReadOnly` entirely!
Ericson2314
force-pushed
the
drainfd-improvements
branch
from
ef254ca to
b489c8e
Compare
edolstra
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
drainFD(both versions)readwrapperGetFileSizewrapperreadFileanddrainFDusing the abovedrainFDinPosixSourceAccessor, avoiding manual IOfromDescriptorReadOnlyentirely!Context
Depends on #15028
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.