nixos/(pretalx): Add mail password from file#485942
Closed
Haennetz wants to merge 1 commit intoNixOS:masterfrom
Closed
nixos/(pretalx): Add mail password from file#485942Haennetz wants to merge 1 commit intoNixOS:masterfrom
Haennetz wants to merge 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
The mail password shouldn't be added as plain text because then it will be stored in the nix store. With the file option we allow to use something like sops
Haennetz
force-pushed
the
add_secrets_by_file
branch
from
7656441 to
57de0b2
Compare
Member
|
This is already possible to configure safely via |
Contributor
Author
Didn’t thought about that option thanks |
Member
|
Sorry, this was for pretix, but a similar approach is coming to pretalx in #486936. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mail password shouldn't be added as plain text because then it will be stored in the nix store. With the file option we allow to use something like sops.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.