Allow overriding the type of the default network #7805
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7795, but I'm not fully convinced about the change.
The problem is that we are always setting the type of default network to be a simulated network, and we also set some other default values. This makes sense, but it does seem to assume that the network is not of type
http. My concern is that a user's settings could interact in the wrong way with those default values.On the other hand, without this change there's no way to have an http network as the default network, something that was possible in HH2.
One alternative here is to re-introduce the
defaultNetworkconfig, and default it to "default" (yes).Another alternative is to only use those default values if the user doesn't change the type, but that starts feeling a bit too complex.