Skip to content

Conversation

@alcuadrado
Copy link
Member

@alcuadrado alcuadrado commented Jan 28, 2026

Please do not merge

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2026

⚠️ No Changeset found

Latest commit: aebd071

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alcuadrado alcuadrado force-pushed the hardhat-exposed-example branch from 75f5179 to 9747f19 Compare January 28, 2026 10:37
@alcuadrado alcuadrado force-pushed the hardhat-exposed-example branch from 9747f19 to 26e590b Compare January 28, 2026 10:39
@github-actions
Copy link
Contributor

hardhat

Total size of the bundle: 243M
Total number of dependencies (including transitive): 48

List of dependencies (sorted by size)
237M	total
37M	@nomicfoundation/edr-linux-x64-musl
37M	@nomicfoundation/edr-linux-x64-gnu
33M	@nomicfoundation/edr-linux-arm64-musl
33M	@nomicfoundation/edr-linux-arm64-gnu
25M	@nomicfoundation/edr-darwin-x64
24M	@nomicfoundation/edr-win32-x64-msvc
21M	@nomicfoundation/edr-darwin-arm64
7.3M	@sentry/core
5.2M	zod
2.7M	micro-eth-signer
1.9M	@noble/curves
1.7M	undici
1.2M	@noble/hashes
1.0M	@nomicfoundation/hardhat-utils
880K	@nomicfoundation/hardhat-vendored
864K	@streamparser/json
624K	micro-packed
592K	tsx
552K	@nomicfoundation/hardhat-errors
492K	@scure/bip39
472K	@nomicfoundation/edr
408K	json-stream-stringify
368K	ethereum-cryptography
344K	fast-equals
332K	@streamparser/json-node
320K	enquirer
320K	@nomicfoundation/hardhat-zod-utils
288K	semver
200K	ws
180K	chokidar
176K	get-tsconfig
168K	@scure/base
160K	esbuild
136K	adm-zip
96K	@scure/bip32
92K	chalk
72K	@nomicfoundation/solidity-analyzer
68K	debug
60K	readdirp
56K	rfdc
48K	ansi-colors
44K	resolve.exports
40K	resolve-pkg-maps
36K	p-map
24K	strip-ansi
24K	env-paths
24K	ansi-regex
20K	ms

Comment on lines +24 to +26
userConfig.paths !== undefined &&
userConfig.paths.exposedContracts !== undefined &&
typeof userConfig.paths.exposedContracts !== "string"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't that be enough ?

Suggested change
userConfig.paths !== undefined &&
userConfig.paths.exposedContracts !== undefined &&
typeof userConfig.paths.exposedContracts !== "string"
typeof userConfig.paths?.exposedContracts !== "string"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that change would make the exposedContracts required.

Maybe a simpler version could be:

const configType = typeof userConfig.paths?.exposedContracts;
if (configType !== "string" && configType !== "undefined) {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually use zod in our plugins though, I kept it with minimal dependencies here because it's an example

@alcuadrado alcuadrado force-pushed the typechain-on-solidity-build branch from dc613c9 to 257bd40 Compare January 30, 2026 13:48
Base automatically changed from typechain-on-solidity-build to main January 30, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants