noice: message, notify, health options

[midischwarz12]

Provides message, notify, and health options to the noice plugin.

Sanity Checking

• I have updated the changelog as per my changes
• I have tested, and self-reviewed my code
• My changes fit guidelines found in hacking nvf
• Style and consistency
  • I ran Alejandra to format my code (nix fmt)
  • My code conforms to the editorconfig configuration of the project
  • My changes are consistent with the rest of the codebase
• If new changes are particularly complex:
  • My code includes comments in particularly complex areas
  • I have added a section in the manual
  • (For breaking changes) I have included a migration guide
• Package(s) built:
  • .#nix (default package)
  • .#maximal
  • .#docs-html (manual, must build)
  • .#docs-linkcheck (optional, please build if adding links)
• Tested on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin

---

Add a 👍 reaction to pull requests you find important.

[github-actions]

🚀 Live preview deployed from 249cabe

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: noice-options

Reruns: 1640

[NotAShelf]

I'm not opposed to merging, but we've generally agree to avoid overpopulating setupOpts since it's already freeform, and adding more options also adds more maintenance burden inbetween plugin updates.

@horriblename @Soliprem wdyt? should we cut poor midi 👨🏻‍🦲 some slack here?

[Soliprem]

Merging sounds good to me. On another (OT) note, I was thinking that linking the docs for plugins we define the freeform setupOpts for might be a good idea, as a thing for the future.

[midischwarz12]

If we resort to freeform setupOpts in the future, shouldn't we just pull the plug then? Seems like early feature block considering that the freeform hasn't been implemented yet.

[horriblename]

If we resort to freeform setupOpts in the future, shouldn't we just pull the plug then? Seems like early feature block considering that the freeform hasn't been implemented yet.

What do you mean?

---

I don't really think this should be merged due to reasons NotAShelf mentioned

[midischwarz12]

If we're going for the freeform route then we should actually remove the existing setOpts options besides what's necessary or being overwritten?

[horriblename]

mkPluginSetupOption is freeform tho

[midischwarz12]

@horriblename Yes, but before making this PR there were still a few unneeded options created such as presets.

Shouldn't these be removed in preference of free form style as well? To the same line of reasoning, these too seem unnecessary.