[17.0][OU-IMP] mail: field_desc and field_type to field_info

[adasatorres]

Possible solution for the following issue #5105 .

[rrebollo]

Looks good but You need to reflect the changes in the upgrade_analysis_work.txt file. Example: openupgrade_scripts/scripts/website_sale/17.0.1.1/upgrade_analysis_work.txt

[MiquelRForgeFlow]

You need to reflect the changes in the upgrade_analysis_work.txt file

Exactly.

[MiquelRForgeFlow]

you have to do something with lines 170-175.

[adasatorres]

@MiquelRForgeFlow Adding the DONE line below line 175 should be enough, right? Also, line 172 has the wrong field type — the field is actually of type jsonb.

[MiquelRForgeFlow]

Adding the DONE line below line 175 should be enough, right?

No, because someone looking into this file will get confused, for duplicated/contradictory information. It's better to amend line 175 and explain your approach there.

Also, line 172 has the wrong field type — the field is actually of type jsonb.

Column type is jsonb, but odoo type is json. The same way you see many2one odoo types there instead of int4.

[pedrobaeza]

@adasatorres can you group together the lines and put for all of them the DONE message for continuing with this?

[adasatorres]

@pedrobaeza I was also thinking of adding the commit ID to the NOTHING TO DO.

[pedrobaeza]

Anyway, I'm checking source code, and it seems that part is only filled when a ir.model.fields is removed:

https://github.com/odoo/odoo/blob/ee1e91ec69c71e783e7f291f8d19a2610c9070a3/addons/mail/models/ir_model_fields.py#L51

but no other reference to that in the rest of tracking references.

I have tried to set the value in one message, and I get an error:

as name key is mandatory, which is not being filled.

Filling that information on a regular tracking value, is not showing nothing extra on the chatter, as field_id is filled and the information is get from there.

On summary, this change is not correct and we can't recreate the information for ir.model.fields unlink trackings, so let's keep it as is.

Which thing brought you to this initially?

[adasatorres]

The migration of project_task_report to version 17.0 is what led me to investigate the mail.tracking.value model. While reviewing the code, I saw that some methods were using that field to store information. I suppose I didn’t review it thoroughly enough — sorry about that. @pedrobaeza