[19.0][MIG] crm_phonecall: migration to 19.0 by eugenios73 · Pull Request #712 · OCA/crm

eugenios73 · 2025-11-28T11:59:45Z

migration crm_phonecall from 18.0 to 19.0

The pre-commit-config update in commit [19.0][FIX] update pre-commit-config is to resolve the "user_id" error issue that was shown in the last pre-commit command and which I commented on in this message #712 (comment)

eugenios73 · 2025-12-01T09:31:21Z

The precommit command fails because it does not seem to be up to date with the change in v19.0 of the "user_ids" attribute of the base model "ir.filters". This attribute has changed compared to v18.0, where it was "user_id". Here is the commit where the change can be seen: odoo/odoo@414e55c

rrebollo

Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.

crm_phonecall/models/crm_lead.py

crm_phonecall/models/crm_phonecall.py

crm_phonecall/models/res_partner.py

crm_phonecall/report/crm_phonecall_report.py

rrebollo · 2025-12-28T03:59:05Z

@eugenios73 could you review mine? #661

* crm_phonecall module (OCA#131) This module is the part extracted from Odoo v8 crm module from Odoo that allows to record phone calls. As it has been stripped off from Odoo v9, we add again the feature via this module. Migration scripts are also included to upgrade a v8 database via OpenUpgrade and don't lose your history. * [MIG] crm_phone_call: Migrated to 10.0 - FIX: Correct some lint errors * [MIG] crm_phone_call: Migrated to 10.0

…reated from phonecall2phonecall wizard.

…ut `date`

Currently translated at 100.0% (150 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/es/

Currently translated at 86.0% (129 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

…ve_id is not correct

Currently translated at 92.7% (139 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

Currently translated at 98.0% (147 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

Currently translated at 27.3% (41 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/

Currently translated at 41.3% (62 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/

Currently translated at 100.0% (153 of 153 strings) Translation: crm-17.0/crm-17.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_phonecall/it/

…r normal users

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-18.0/crm-18.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall/

Currently translated at 99.3% (152 of 153 strings) Translation: crm-18.0/crm-18.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall/es/

Reyes4711-S73

LGTM

rrebollo · 2026-01-20T19:17:57Z

.pre-commit-config.yaml

I believe this type of contribution should be managed in a separate pull request. Then we can base this work on top of it.

@rrebollo new PR with the pre-commit-config changes #724

OCA-git-bot · 2026-01-20T19:43:44Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

eugenios73 force-pushed the 19.0-mig-crm_phonecall branch 3 times, most recently from d0ec288 to b5cae86 Compare December 1, 2025 09:01

rrebollo approved these changes Dec 28, 2025

View reviewed changes

cubells and others added 24 commits January 15, 2026 15:20

[IMP] Add smartbutton to leads and opportunities

36f38cf

[IMP][crm_phonecall] Add utm.mixin fields

a8d56e7

crm_phonecall: Fix action to redirect to the new phonecall when its c…

f7abdfd

…reated from phonecall2phonecall wizard.

[FIX] crm_phonecall: C8108(method-compute) + E8103(sql-injection)

d3f5401

[MIG] crm_phonecall: Migration to 11.0

26d45a0

crm_phonecall: fixes to skip duration computation on phonecalls witho…

fd14b41

…ut `date`

[MIG] crm_phonecall: Migration to 12.0.

852c7c6

Translated using Weblate (Spanish)

cbac13d

Currently translated at 100.0% (150 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/es/

Translated using Weblate (German)

cf8e73f

Currently translated at 86.0% (129 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

[FIX] crm_phonecall: make states editable

ff49c34

[FIX] crm_phonecall: when accessing from partner's opportunities acti…

2a3a276

…ve_id is not correct

Translated using Weblate (German)

55f0510

Currently translated at 92.7% (139 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

Translated using Weblate (German)

6e42d72

Currently translated at 98.0% (147 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

[FIX] crm_phonecall button size

457a1ad

Translated using Weblate (Croatian)

e1f47dd

Currently translated at 27.3% (41 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/

[IMP] crm_phonecall UI Phonecall button next to Meetings

4f95958

Translated using Weblate (Croatian)

779709c

Currently translated at 41.3% (62 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/

[IMP] crm_phonecall: black, isort

d315c4c

[MIG] crm_phonecall: Migration to 13.0

71e1ba3

[UPD] Update crm_phonecall.pot

49a339a

Update translation files

6f2c1fe

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/

[IMP] crm_phonecall: Add field direction in calls and improve views.

0b54545

[IMP] crm_phonecall: Add new group to enable form view for phone calls.

32611f8

Antoni Marroig Campomar and others added 16 commits January 15, 2026 15:20

[MIG] crm_phonecall: Migration to 17.0

ede428e

Translated using Weblate (Italian)

602dc3d

Currently translated at 100.0% (153 of 153 strings) Translation: crm-17.0/crm-17.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_phonecall/it/

Translated using Weblate (Italian)

92e0be8

Currently translated at 100.0% (153 of 153 strings) Translation: crm-17.0/crm-17.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_phonecall/it/

[MIG] crm_phonecall: Migration to 18.0

4a6e133

[UPD] Update crm_phonecall.pot

2b466c8

[BOT] post-merge updates

382844a

[FIX]crm_phonecall: Fixed invisible oportunity issue

8d69103

[BOT] post-merge updates

92162f8

[FIX] crm_phonecall: prevent access error to ir.actions.act_window fo…

3588004

…r normal users

[BOT] post-merge updates

608407f

[UPD] Update crm_phonecall.pot

d81d4f1

Update translation files

e1b7e78

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-18.0/crm-18.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall/

[UPD] Update crm_phonecall.pot

7792a5e

Update translation files

7c46c2b

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-18.0/crm-18.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall/

Translated using Weblate (Spanish)

3bb2ace

Currently translated at 99.3% (152 of 153 strings) Translation: crm-18.0/crm-18.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall/es/

Translated using Weblate (Spanish)

19b7cf5

Currently translated at 99.3% (152 of 153 strings) Translation: crm-18.0/crm-18.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall/es/

eugenios73 force-pushed the 19.0-mig-crm_phonecall branch 2 times, most recently from ebca7da to d9fd486 Compare January 15, 2026 15:11

Reyes4711-S73 approved these changes Jan 15, 2026

View reviewed changes

OCA-git-bot added the approved label Jan 15, 2026

eugenios73 force-pushed the 19.0-mig-crm_phonecall branch 3 times, most recently from 789e587 to f003208 Compare January 20, 2026 12:32

[19.0][MIG] crm_phonecall

54ad4d8

eugenios73 force-pushed the 19.0-mig-crm_phonecall branch from f003208 to a6a52fe Compare January 20, 2026 13:05

rrebollo reviewed Jan 20, 2026

View reviewed changes

OCA-git-bot added the ready to merge label Jan 20, 2026

eugenios73 force-pushed the 19.0-mig-crm_phonecall branch 2 times, most recently from ffdb018 to 54ad4d8 Compare January 21, 2026 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] crm_phonecall: migration to 19.0#712

[19.0][MIG] crm_phonecall: migration to 19.0#712
eugenios73 wants to merge 76 commits intoOCA:19.0from
Studio73:19.0-mig-crm_phonecall

eugenios73 commented Nov 28, 2025 •

edited

Loading

Uh oh!

eugenios73 commented Dec 1, 2025

Uh oh!

rrebollo left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrebollo commented Dec 28, 2025

Uh oh!

Reyes4711-S73 left a comment

Uh oh!

rrebollo Jan 20, 2026

Uh oh!

eugenios73 Jan 21, 2026

Uh oh!

OCA-git-bot commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

eugenios73 commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eugenios73 commented Dec 1, 2025

Uh oh!

rrebollo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rrebollo commented Dec 28, 2025

Uh oh!

Reyes4711-S73 left a comment

Choose a reason for hiding this comment

Uh oh!

rrebollo Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

eugenios73 Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

eugenios73 commented Nov 28, 2025 •

edited

Loading