[19.0][MIG] project_template: Migration to 19.0#1617
Open
Vang-NguyenPhu wants to merge 64 commits intoOCA:19.0from
Open
[19.0][MIG] project_template: Migration to 19.0#1617Vang-NguyenPhu wants to merge 64 commits intoOCA:19.0from
Vang-NguyenPhu wants to merge 64 commits intoOCA:19.0from
Conversation
Adding new Project Template Module [FIX] PEP8 Errors Revert "[FIX] PEP8 Errors" This reverts commit 90f9cd9. [FIX] Fixed PEP8 Formatting First upload tests showed some lint issues which this commit has the fixes for. [FIX] Fixed LINT Issue Removed unreachable code that was not needed. [FIX] RunBot Warning Fixed runbot warning about @Class to hasclass [UPD] Suggested Changes Updated based on suggested changes on other submitted modules. [UPD] Manifest and Readme Updated Manifest and Readme based on comments on other module pr's. [UPD] Suggested Changes Updated code based on suggested code changes from reviewer. [FIX] Creation Error Fixed create project error when creating project via configuration/projects menu [UPD] Menu and Bool Change Removed Template Menu (Filter option still there) and moved Bool up below name. (From reviewer suggestions) [UPD] Kanban Menu Removed button, added link to kanban menu. Start of tests [UPD] Remove project_milestone code Removed the project_milestone code and will create a separate module for that purpose.
Currently translated at 100.0% (7 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/
There is an error if the template name gets modified so needed to add a new else statement for the new_name.
Currently translated at 100.0% (7 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/pt/
Currently translated at 85.7% (6 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/fr/
Currently translated at 100.0% (7 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/sl/
Currently translated at 14.3% (1 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-13.0/project-13.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_template/
Currently translated at 100.0% (7 of 7 strings) Translation: project-13.0/project-13.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_template/he/
Currently translated at 100.0% (10 of 10 strings) Translation: project-16.0/project-16.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/de/
Currently translated at 100.0% (7 of 7 strings) Translation: project-16.0/project-16.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/hr/
Currently translated at 100.0% (7 of 7 strings) Translation: project-16.0/project-16.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/it/
Currently translated at 100.0% (7 of 7 strings) Translation: project-16.0/project-16.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/pt_BR/
Currently translated at 85.7% (6 of 7 strings) Translation: project-16.0/project-16.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/nl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-16.0/project-16.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/
Previously, if multiple tasks in a template project had the same name, their end_date-values were not copied properly. Co-authored-by: Stefan Rijnhart <stefan@opener.amsterdam>
* Change the way to copy end dates to tasks due to api change to _map_tasks_default_values which now longer gets passed the task * Refactor tests to use setUpClass (finally) * Update overwritten action context with upstream changes * Remove originally unmodified (but now outdated) fields from overwritten action * Update kanban element selector
41 tasks
Contributor
|
/ocabot migration project_template |
Quan-nhm
approved these changes
Jan 9, 2026
Quan-nhm
left a comment
Quan-nhm
left a comment
There was a problem hiding this comment.
Functional Test and Code review LGTM!
Contributor
|
This PR has the |
Contributor
|
Hello @Vang-NguyenPhu could you quickly take the time to reduce a bit the administrative commits? https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.