[19.0][MIG] bi_sql_editor: Migration to 19.0 by lef-adhoc · Pull Request #1102 · OCA/reporting-engine

lef-adhoc · 2025-11-28T14:56:52Z

Depends on:

[19.0][MIG] sql_request_abstract: Migration to 19.0 #1101

…ield; [ADD] security

…fresh date time on the action name of each sql materialized view

Fix error '... is not a table or foreign table' Fix view (colors + oe_highlight) Fix tests Fix README + manifest Fix back to draft Fix cron call + default values Use Postgres version 9.6 for travis builds

* [IMP] is_materialized field non readonly on sql_valid state ; [FIX] block possibility to set indexes on non materialized view * [FIX] set domain_force, group_ids readonly if state > sql_valid * [IMP] better display of the field group_ids * [IMP] possibility to reorder menu items from sql views * [IMP] Do not warn user when setting sql view to draft if state is sql_valid * [REF] * [FIX] Set Date of the first execution in the action name

[UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

bi_sql_editor 12.0.1.1.0 [UPD] README.rst [UPD] README.rst

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/

Currently translated at 29.1% (32 of 110 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/de/

Fixes OCA#309

yankinmax · 2025-12-16T13:31:28Z

bi_sql_editor/tests/test_bi_sql_view.py

    def _get_user(cls, access_level=False):
        if access_level == "manager":
-            cls.demo_user.write({"groups_id": [(6, 0, cls.group_bi_manager.ids)]})
+            cls.demo_user.write({"group_ids": [(6, 0, cls.group_bi_manager.ids)]})


Can you check the commit “[MIG] bi_sql_editor: Migration to 19.0”? It's like that.

yankinmax

Thanks for taking care of suggestions

vvrossem

I agree with @yankinmax: it would be a nice opportunity to use Command instead of keeping the "old" way

vvrossem · 2026-01-09T14:57:03Z

bi_sql_editor/demo/res_groups_demo.xml

    </record>
    <record id="sql_request_abstract.group_sql_request_user" model="res.groups">
-        <field name="users" eval="[(4, ref('base.user_demo'))]" />
+        <field name="user_ids" eval="[(4, ref('base.user_demo'))]" />


Suggested change

<field name="user_ids" eval="[(4, ref('base.user_demo'))]" />

<field name="user_ids" eval="[Command.link(ref('base.user_demo'))]" />

vvrossem · 2026-01-09T15:03:09Z

bi_sql_editor/tests/test_bi_sql_view.py

@@ -3,11 +3,11 @@

 from odoo.exceptions import AccessError, UserError, ValidationError
 from odoo.tests import tagged


Suggested change

from odoo.tests import tagged

from odoo.tests import new_test_user, tagged

vvrossem · 2026-01-09T15:03:51Z

bi_sql_editor/tests/test_bi_sql_view.py

        cls.group_bi_no_access = cls.env.ref("base.group_user")
-        cls.demo_user = cls.env.ref("base.user_demo")
-        cls.view = cls.env.ref("bi_sql_editor.partner_sql_view")
+        cls.demo_user = cls.env["res.users"].create(


Suggested change

cls.demo_user = cls.env["res.users"].create(

cls.demo_user = new_test_user(cls.env, login='demo_bi_sql', groups='base.group_user', name='Demo User', email='demo@example.com')

psugne · 2026-01-13T10:36:23Z

@lef-adhoc how is going with this one?

lef-adhoc · 2026-01-13T15:02:14Z

@vvrossem @psugne Done!

psugne · 2026-01-27T08:35:18Z

@lef-adhoc Would it be possible to update TestBiSqlViewEditor.test_security to search for the view by ID instead of name? For example:
def test_security(self): with self.assertRaises(AccessError): self.bi_sql_view.with_user(self._get_user()).search( [("id", "=", self.view.id)] ) bi = self.bi_sql_view.with_user(self._get_user("manager")).search( [("id", "=", self.view.id)] ) self.assertEqual( len(bi), 1, f"BI Manager should have access to the specific record: {self.view.name}", )

When running this test in my module, it currently fails due to search mismatches:
AssertionError: 2 != 1 : BI Manager should have access to bi Partners View
Searching by ID instead of name should make the test more deterministic and avoid collisions when multiple records share the same name.

yankinmax · 2026-02-02T09:53:53Z

Hello @lef-adhoc , can you pls address the suggestions and finish the migration?

lef-adhoc · 2026-02-02T15:01:30Z

@yankinmax Done!

yankinmax · 2026-02-02T15:17:58Z

@lef-adhoc the related PR is merged, and we can ping maintainers to merge this one. Can you update?

yankinmax · 2026-02-02T15:45:23Z

Hello @HviorForgeFlow
Sorry, pinging you directly.
Can we probably merge this migration PR?

lef-adhoc · 2026-02-02T15:46:04Z

@yankinmax Done, I deleted the commit

OCA-git-bot · 2026-02-02T15:49:09Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

HviorForgeFlow · 2026-02-02T15:49:24Z

/ocabot merge nobump

OCA-git-bot · 2026-02-02T15:49:36Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-1102-by-HviorForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot · 2026-02-02T15:53:15Z

Congratulations, your PR was merged at 429646a. Thanks a lot for contributing to OCA. ❤️

legalsylvain and others added 30 commits November 28, 2025 11:22

new module bi_sql_editor [IMP] function to guess model for many2one f…

cf86623

…ield; [ADD] security

OCA Transbot updated translations from Transifex

f74e3ee

bi_sql_editor

33e3d99

create ui now create tree view [IMP] fr translation [IMP] add last re…

cf6df94

…fresh date time on the action name of each sql materialized view

[IMP] Add test + several fixes

a626cf0

OCA Transbot updated translations from Transifex

d2b99ad

FIX bi_sql_editor

cca0fd4

[MIG] bi_sql_editor v10

3fc1231

[IMP] preview button

c89832e

Fix several issues

65498de

Fix error '... is not a table or foreign table' Fix view (colors + oe_highlight) Fix tests Fix README + manifest Fix back to draft Fix cron call + default values Use Postgres version 9.6 for travis builds

[UPD] Update bi_sql_editor.pot

4234f8e

[MIG] bi_sql_editor: Migration to 11.0

a92cf53

[FIX] Can be upgraded with materialized views generated

5fdfc4b

[FIX] ir.cron relation

7fea29e

[IMP] remove unneeded parenthesis

840b0f8

[FIX] Solves the upgrading problem

e15f224

[FIX] Query and technical name should only be modifiable in draft mode

4136c09

[UPD] Update bi_sql_editor.pot

dcf0d9e

[UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot

Update translation files

b9c64e7

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[12.0][MIG] Migrate module bi_sql_editor to v12

e3b85d7

[FIX] bi_sql_editor: add in readme how to solve the update all break

0f5d0e5

Update readme

1ae6137

bi_sql_editor 12.0.1.2.0

aa601f9

bi_sql_editor 12.0.1.1.0 [UPD] README.rst [UPD] README.rst

Translated using Weblate (German)

8c87cf6

Currently translated at 29.1% (32 of 110 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/de/

[FIX] bi_sql_editor: Fixes images path

a80ef9d

Fixes OCA#309

[FIX] bi_sql_editor: Add required attribute name on filters

ce79985

change SQL mapping for date

9e9be79

[ADD] action context

8692e97

yankinmax reviewed Dec 16, 2025

View reviewed changes

yankinmax approved these changes Dec 16, 2025

View reviewed changes

lef-adhoc force-pushed the 19.0-mig-bi_sql_editor branch from 4927854 to 3144fdc Compare December 16, 2025 14:56

lef-adhoc force-pushed the 19.0-mig-bi_sql_editor branch 2 times, most recently from 8cc1347 to b66eb95 Compare December 31, 2025 15:04

vvrossem approved these changes Jan 9, 2026

View reviewed changes

OCA-git-bot added the approved label Jan 9, 2026

lef-adhoc force-pushed the 19.0-mig-bi_sql_editor branch from b66eb95 to 887773e Compare January 13, 2026 14:49

[MIG] bi_sql_editor: Migration to 19.0

088160d

lef-adhoc force-pushed the 19.0-mig-bi_sql_editor branch from 887773e to f31b335 Compare February 2, 2026 15:01

lef-adhoc force-pushed the 19.0-mig-bi_sql_editor branch from f31b335 to 088160d Compare February 2, 2026 15:44

HviorForgeFlow approved these changes Feb 2, 2026

View reviewed changes

OCA-git-bot added the ready to merge label Feb 2, 2026

OCA-git-bot added the bot is merging ⏳ label Feb 2, 2026

OCA-git-bot merged commit fdd707b into OCA:19.0 Feb 2, 2026
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 2, 2026

lef-adhoc deleted the 19.0-mig-bi_sql_editor branch February 2, 2026 15:54

	<field name="user_ids" eval="[(4, ref('base.user_demo'))]" />
	<field name="user_ids" eval="[Command.link(ref('base.user_demo'))]" />

		@@ -3,11 +3,11 @@

		from odoo.exceptions import AccessError, UserError, ValidationError
		from odoo.tests import tagged

	from odoo.tests import tagged
	from odoo.tests import new_test_user, tagged

	cls.demo_user = cls.env["res.users"].create(
	cls.demo_user = new_test_user(cls.env, login='demo_bi_sql', groups='base.group_user', name='Demo User', email='demo@example.com')

Uh oh!

Conversation

lef-adhoc commented Nov 28, 2025 • edited by HviorForgeFlow Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yankinmax Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

lef-adhoc Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

yankinmax left a comment

Choose a reason for hiding this comment

Uh oh!

vvrossem left a comment

Choose a reason for hiding this comment

Uh oh!

vvrossem Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

vvrossem Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

vvrossem Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

psugne commented Jan 13, 2026

Uh oh!

lef-adhoc commented Jan 13, 2026

Uh oh!

psugne commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yankinmax commented Feb 2, 2026

Uh oh!

lef-adhoc commented Feb 2, 2026

Uh oh!

yankinmax commented Feb 2, 2026

Uh oh!

yankinmax commented Feb 2, 2026

Uh oh!

lef-adhoc commented Feb 2, 2026

Uh oh!

OCA-git-bot commented Feb 2, 2026

Uh oh!

HviorForgeFlow commented Feb 2, 2026

Uh oh!

OCA-git-bot commented Feb 2, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

lef-adhoc commented Nov 28, 2025 •

edited by HviorForgeFlow

Loading

psugne commented Jan 27, 2026 •

edited

Loading