[18][FIX] dbfilter_from_header: db name matching has to be strict#3495
Open
[18][FIX] dbfilter_from_header: db name matching has to be strict#3495
Conversation
thomaspaulb
approved these changes
Jan 18, 2026
hbrunn
requested changes
Jan 22, 2026
Member
hbrunn
left a comment
There was a problem hiding this comment.
this is supposed to do exactly what https://github.com/OCA/OCB/blob/18.0/odoo/http.py#L380 does but for headers, so I disagree with this change.
Your case should be handled with appending a $ sign, just as you'd do it if the dbfilter was in the config file. As this seems to be unclear, I suggest to change your PR to an amendment of the readme clarifying this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use case :
We have 2 databases dbname and dbname-test
In case we setup the dbfilter to dbname, we have 2 databases that match.
So we are donig a strict match now (re.fullmatch since python 3.4)