Skip to content

[15.0][IMP] onchange_helper: Support one2many fields in onchanges #3515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedrobaeza wants to merge 1 commit into
base: 15.0
Choose a base branch
from
+16 −2
Open

[15.0][IMP] onchange_helper: Support one2many fields in onchanges #3515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions onchange_helper/models/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,16 @@ def _get_new_values(self, record, on_change_result):
for fieldname, value in vals.items():
if fieldname not in record:
column = self._fields[fieldname]
if value and column.type == "many2one":
if column.type == "one2many":
submodel = self.env[column.comodel_name]
for vals in value:
if vals[0] == 0:
# CREATE command
for elem in vals[2]:
subcolumn = submodel._fields[elem]
if subcolumn.type == "many2one" and vals[2][elem]:
vals[2][elem] = vals[2][elem][0]
elif value and column.type == "many2one":
value = value[0] # many2one are tuple (id, name)
new_values[fieldname] = value
return new_values
Expand All @@ -33,7 +42,12 @@ def play_onchanges(self, values, onchange_fields):
# _onchange_spec() will return onchange fields from the default view
# we need all fields in the dict even the empty ones
# otherwise 'onchange()' will not apply changes to them
onchange_specs = {field_name: "1" for field_name, field in self._fields.items()}
onchange_specs = {}
for field_name, field in self._fields.items():
onchange_specs[field_name] = "1"
if field.type == "one2many":
for sub_field_name in self.env[field.comodel_name]._fields.keys():
onchange_specs[f"{field_name}.{sub_field_name}"] = "1"
all_values = values.copy()
# If self is a record (play onchange on existing record)
# we take the value of the field
Expand Down