[18.0][IMP] date_range: Set multicompanies support for the date.range model

[Andrii9090-tecnativa]

The date.range model currently supports only a single company (company_id).
This requires creating multiple date ranges for different companies, which complicates management.
To resolve this, we replace the field company_id with company_ids (Many2many) in the model date.range

It's a short video with funcional test
https://www.loom.com/share/f1a0719eafa443058e3a0befc0eed9b4?sid=fbbd55c0-f75d-48aa-b9ec-d93e28af320f

Issue
@moduon
MT-10678

[OCA-git-bot]

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

[cav-adhoc]

LGTM

[Andrii9090-tecnativa]

Hi @lmignon can you review this PR?

Thanks ❤️

[rafaelbn]

Hello @StefanRijnhart , @sbidoul @lmignon ✋🏼

Please could you please take a look here just a quick review? 🙏🏼 😄

Thank you!!!! ❤️
Rafael

[EmilioPascual]

@Andrii9090 can you rebase it for review it functionally? Thank you.

[Andrii9090-tecnativa]

@EmilioPascual runboat is available, you can functionally review it.

[EmilioPascual]

LGTM. Functional and code review.

Good work @Andrii9090

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[Andrii9090-tecnativa]

Hello @StefanRijnhart , @sbidoul @lmignon

Please could you take a look this PR just a quick review?

[Gelojr]

Congratulations on the great work on this PR @Andrii9090 .
The following functional tests have been performed with the results indicated below.

• Test 1: Creation of a minimal Date Range Type – OK
• Test 2: Multi-company Date Range creation using company_ids – OK
• Test 3: Creation of a global Date Range without companies – OK
• Test 4: Overlap blocking when Date Ranges share at least one company and overlap is not allowed – OK
• Test 5: Overlap allowed when Date Ranges do not share any company – OK
• Test 6: Consistency check between Date Range Type company_id and Date Range company_ids – OK
• Test 7: Generate Date Ranges wizard creates Date Ranges with company_ids correctly set – OK
• Test 8: Multi-company record rule visibility based on company_ids – OK
• Test 9: Generate Date Ranges wizard with empty Company field generates global Date Ranges only (no duplication per company) – OK

[yajo]

Code review.

[yajo]

Some comments to improve code. Mostly OK. Thanks!

[yajo]

/ocabot merge major

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1172-by-yajo-bump-major, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 13b8528. Thanks a lot for contributing to OCA. ❤️

[carlos-lopez-tecnativa]

These changes are causing an error in the module: https://github.com/OCA/account-financial-reporting/blob/dcb2a3ed073c767f6ebc2181e5921825bb230a55/account_financial_report/wizard/general_ledger_wizard.py#L224

[christian-ramos-tecnativa]

Fixed here OCA/account-financial-reporting#1437

[sbidoul]

This is also breaking mis_builder. Is there no way to achieve the use case while keeping some backward compatibility?

[sbidoul]

@rafaelbn @yajo @Andrii9090 what do you think? Any chance to introduce some backward compatibility. In OCA/mis-builder#758 (comment), @pedrobaeza is suggesting a searchable company_id field.

[yajo]

Apologies! I didn't realize the impact when I reviewed it.

We can use https://github.com/OCA/multi-company/blob/18.0/base_multi_company/models/multi_company_abstract.py to get the backwards compatibility.

[pedrobaeza]

We can't add a new dependency in the modules...

[sbidoul]

We can't add a new dependency in the modules...

Why not?

[yajo]

Yes, we do that all the time...

[yajo]

See #1227.

[andreampiovesana]

this break all report that use date_range and company_id instead company_ids
you break many apps!
for italy:

• l10n_it_financial_statements_report

[juancarlosonate-tecnativa]

This change is severely impacting modules. Because of this, I strongly believe the change should be reverted and properly analyzed in more depth.

[alexis-via]

@Andrii9090 If you want to share date.range across companies, set company_id to False (it is not a required field, cf https://github.com/OCA/server-ux/blob/17.0/date_range/models/date_range.py#L30 , and it is on purpose !) and you will be able to use the date.range from all the companies. I often do that in my multi-company deployments and it works well.