Enable processing CW/FM interleaving data [all tests ci]#1508
Open
leewujung wants to merge 86 commits intoOSOceanAcoustics:mainfrom
Open
Enable processing CW/FM interleaving data [all tests ci]#1508leewujung wants to merge 86 commits intoOSOceanAcoustics:mainfrom
leewujung wants to merge 86 commits intoOSOceanAcoustics:mainfrom
Conversation
Attempt at fixing OSOceanAcoustics#1377.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…nominal and slope
for more information, see https://pre-commit.ci
…d corresponding test
… setting them as separate beam groups
…N in the trasmit signal parameters and add FM/CW interleaving and channel multiplexing test
Collaborator
|
@leewujung This is ready for review |
This was referenced Dec 4, 2025
…roup is not used for ek60 data
Member
Author
|
@ctuguinay I just pulled in the recent pin for pandas<3 because that's giving errors in the compute_MVBS test (but it'll be fine once flox has a new release). I'll wait for the test to run through and then review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #1506 and #1507 in one go, since they are tightly linked.
@ctuguinay : I think I've only gotten to store ping-by-ping filter coefficients (FIL1 datagram), but it's been a while so my memory is pretty faded. Please check. Thanks a lot for picking this up!