feat: updated navbar #141
Open
feat: updated navbar #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fionnachan
reviewed
Feb 12, 2026
| handleSelection: (item: SearchResult) => void; | ||
| }) => { | ||
| const pathname = usePathname(); | ||
| const isOnBridgePage = pathname.startsWith('/bridge'); |
Member
There was a problem hiding this comment.
i think he meant this one
https://arbitrum-portal-git-feat-new-navbar-offchain-labs.vercel.app/projects/bridges-and-on-ramps
seems ok?
chrstph-dvx
reviewed
Feb 12, 2026
| ref={inputRef} | ||
| type="text" | ||
| className="h-full w-full bg-transparent text-sm text-white placeholder-white/50 outline-none focus:outline-none focus:ring-0 focus:ring-offset-0 shadow-none" | ||
| name="portal-search" |
Contributor
There was a problem hiding this comment.
Do we use it anywhere?
Contributor
Author
There was a problem hiding this comment.
There was an a11y warning in HTML to have id or name with an input element. this fixed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.