fix(security): prevent potential SQL injection in TableCounts #368
+72
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3rabiii
force-pushed
the
fix/sql-injection-table-counts
branch
from
ee18b29 to
f5f8229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses the High Severity security vulnerability identified in
gtfsdb/debugging.go.The original implementation of
TableCountsconstructed SQL queries using string interpolation (fmt.Sprintf), which is flagged as a potential SQL Injection vector despite the map-based check.Changes:
switch-caseallowlist. This ensures the executed SQL queries are constant strings, eliminating any risk of injection.allowedTablesmap.gtfsdb/debugging_test.gowith a new unit testTestTableCountsto verify:Verification
@aaronbrethorst
fixes : #367