Open
Conversation
…e housekeeping/readability
…s but does standup the session
…ll never recover even after 3 attempts. change attempts to 3, change interval to 0.5
…st & we'll never recover even after 3 attempts. change attempts to 3, change interval to 0.5" This reverts commit d848402.
…ntralize cookie/name handling
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sizeable refactor to the easy netplay scripts, some small behavioural changes.. Mostly structural to make it easier to maintain.
I've tested the scripts w/ Pokemon Red, Blue (GB/GBC scripts) and FireRed / LeafGrean (GB/GBA scripts), Balloon kid (Standard EN Scripts)
A few disconnects across many tests, likely due to the network card as unreproducable and entirely random (Which happened in previous EN versions anyway)
Not tested on Mini Flip as i don't have the devices.
Shared helpers moved into easy-netplay_common.sh
Shared helpers moved into easy-netplay_signalling.sh
Shared env setup moved into easy-netplay_env.sh