Enable -Wall and "fix" warnings#2474
Merged
fenhl merged 2 commits intoOoTRandomizer:Devfrom Oct 25, 2025
Merged
Conversation
GSKirox
added
Component: ASM/C
Author
|
Also, |
fenhl
approved these changes
Oct 12, 2025
cjohnson57
removed
the
Status: Under Consideration
fenhl
added a commit
that referenced
this pull request
Nov 25, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I enabled
-WallinCFLAGSand then "fixed" all of the warnings. The code should be functionally the same, but a lot of unused code was removed. Some of this may have been for reference purposes, in which case I can restore it most likely commented out instead of unused.Also, if this isn't to be merged, code like
uint8_t nbOverlays, currentOverlayTabIndex = 0;should probably be disallowed in code style as only the last variable gets the initialized. (thanks C)Testing
Ensured the game still boots. Shirosoluna helped testing to make sure I didn't make any functional changes to the code related to equip swap.