Skip to content

Make BGS and Giant's Knife Advancement Items for Logic Consideration #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fenhl merged 5 commits into from
Dec 5, 2025
Merged

Make BGS and Giant's Knife Advancement Items for Logic Consideration #2475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3377411
Make Biggoron Sword and Giant's Knife Advancement items to conform wi…
dotzo Oct 6, 2025
fd0ea9f
new trick water iron boots dive
shirosoluna Oct 24, 2025
a23e355
trailing spaces
shirosoluna Oct 24, 2025
270bd1f
fix typo, remove 1164 hints.py per r0bdog
shirosoluna Nov 5, 2025
6b616ec
remove water trick
shirosoluna Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Hints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,7 +1161,6 @@ def get_important_check_hint(spoiler: Spoiler, world: World, checked: set[str])
and not location.item.name == 'Triforce Piece'
and not (location.name == 'Song from Impa' and 'Zeldas Letter' in world.settings.starting_items and 'Zeldas Letter' not in world.settings.shuffle_child_trade)
# Special cases where the item is only considered major for important checks hints
or location.item.name == 'Biggoron Sword'
or location.item.name == 'Double Defense'
# Handle make keys not in own dungeon major items
or (location.item.type in ('SmallKey', 'SmallKeyRing') and not (world.settings.shuffle_smallkeys == 'dungeon' or world.settings.shuffle_smallkeys == 'vanilla'))
Expand Down
4 changes: 2 additions & 2 deletions ItemList.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ class GetItemId(IntEnum):
'Eyedrops': ('Item', True, GetItemId.GI_EYE_DROPS, {'trade': True}),
'Claim Check': ('Item', True, GetItemId.GI_CLAIM_CHECK, {'trade': True}),
'Kokiri Sword': ('Item', True, GetItemId.GI_SWORD_KOKIRI, None),
'Giants Knife': ('Item', None, GetItemId.GI_SWORD_KNIFE, None),
'Giants Knife': ('Item', True, GetItemId.GI_SWORD_KNIFE, None),
'Deku Shield': ('Item', None, GetItemId.GI_SHIELD_DEKU, None),
'Hylian Shield': ('Item', None, GetItemId.GI_SHIELD_HYLIAN, None),
'Mirror Shield': ('Item', True, GetItemId.GI_SHIELD_MIRROR, None),
Expand Down Expand Up @@ -394,7 +394,7 @@ class GetItemId(IntEnum):
'Gerudo Mask': ('Item', None, GetItemId.GI_MASK_GERUDO, {'trade': True, 'object': 0x0152}),
'Rupees (50)': ('Item', None, GetItemId.GI_RUPEE_PURPLE, {'junk': 1}),
'Rupees (200)': ('Item', None, GetItemId.GI_RUPEE_GOLD, {'junk': 0}),
'Biggoron Sword': ('Item', None, GetItemId.GI_SWORD_BIGGORON, None),
'Biggoron Sword': ('Item', True, GetItemId.GI_SWORD_BIGGORON, None),
'Fire Arrows': ('Item', True, GetItemId.GI_ARROW_FIRE, None),
'Ice Arrows': ('Item', True, GetItemId.GI_ARROW_ICE, None),
'Blue Fire Arrows': ('Item', True, GetItemId.GI_ARROW_ICE, None),
Expand Down