Skip to content

Fast Goron vase#2523

Open
GSKirox wants to merge 1 commit intoOoTRandomizer:Devfrom
GSKirox:fast_goron_vase
Open

Fast Goron vase#2523
GSKirox wants to merge 1 commit intoOoTRandomizer:Devfrom
GSKirox:fast_goron_vase

Conversation

@GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Jan 30, 2026

In child Goron City, removes the cutscene of the vase spinning when throwing a bomb in it, and makes the item drop instantly instead of waiting for the vase to spin.

2026-01-30.09-16-08.mp4

Testing

Tested that it worked (Retroarch) as can be seen on the video above. Here is a test patch of main dev + this change.
Starting in goron city as child with bombs/dins/magic/sticks.
OotR_test_fast_goron_vase.zip

@GSKirox GSKirox added Type: Enhancement New feature or request Status: Needs Review Someone should be looking at it Status: Under Consideration Developers are considering whether to accept or decline the feature described Component: Patching Affects the patching of the ROM labels Jan 30, 2026
@r0bd0g
Copy link

r0bd0g commented Jan 30, 2026

Are you sure this would have the same timing as if the pot still needed to spin?
Does the pot come to a rest in the same position it would have before?

@GSKirox
Copy link
Collaborator Author

GSKirox commented Jan 30, 2026

This is actually a concern yeah, and i'm not sure i can confidently answer.
The prize is chosen according to the direction the vase is facing 140 frames after the explosion, and the direction keeps spinning at different values the whole cutscene.
With this, it just looks at the vase's direction 1 frame after the explosion.
The important part is where the vase actually ends up facing, but yeah i can't guarantee the values are strictly the same with this. Maybe it's too risky of a change then.

@fenhl
Copy link
Collaborator

fenhl commented Feb 3, 2026

How many possible rotation values are there? Would it be feasible to check the math for all of them?

@r0bd0g
Copy link

r0bd0g commented Feb 3, 2026

Doesn't it move in a circle in addition to rotating?

@fenhl
Copy link
Collaborator

fenhl commented Feb 3, 2026

Yes but I assume this doesn't affect the drop selection.

@r0bd0g
Copy link

r0bd0g commented Feb 3, 2026

The position of the vase matters if you need to go again, perhaps if you got the wrong face or are on shuffled freestandings or need to farm bombs or rupees. The position of the vase matters a lot for whether the throw is even possible, especially if you're not able to use bombs.

@fenhl
Copy link
Collaborator

fenhl commented Feb 3, 2026

That's true, I guess we should reset the position as well.

@r0bd0g
Copy link

r0bd0g commented Feb 3, 2026

I guess you'd have to calculate what the final position and rotation would have been and teleport it.

@fenhl
Copy link
Collaborator

fenhl commented Feb 3, 2026

Does the final position depend on timing? If so, does the final position affect the path the pot takes during normal movement, or only its starting point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Patching Affects the patching of the ROM Status: Needs Review Someone should be looking at it Status: Under Consideration Developers are considering whether to accept or decline the feature described Type: Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants