cas_cache: fix "blk_update_request: operation not supported" error#1213
Open
hammerg wants to merge 1 commit intoOpen-CAS:masterfrom
Open
cas_cache: fix "blk_update_request: operation not supported" error#1213hammerg wants to merge 1 commit intoOpen-CAS:masterfrom
hammerg wants to merge 1 commit intoOpen-CAS:masterfrom
Conversation
A write request with the REQ_RAHEAD flag enabled cause the nvme driver to send a write command with access frequency value that is reserved (at least on specification version 1.4c). NVME devices might fail this write command with an unsupported error. So we now clear the request's flag based on its direction. Signed-off-by: Gal Hammer <gal.hammer@huawei.com> Signed-off-by: Shai Fultheim <shai.fultheim@huawei.com>
|
Can one of the admins verify this patch? |
Contributor
|
@CAS-Linux-Jenkins ok to test |
Author
|
Anyone? Thanks, Gal. |
kajakoltan
requested review from
arutk,
jfckm,
kmajzero,
mmichal10,
rafalste and
robertbaldyga
rafalste
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A write request with the REQ_RAHEAD flag enabled cause the nvme driver
to send a write command with access frequency value that is reserved
(at least on specification version 1.4c). NVME devices might fail this
write command with an unsupported error. So we now clear the request's
flags based on its direction.
Signed-off-by: Gal Hammer gal.hammer@huawei.com
Signed-off-by: Shai Fultheim shai.fultheim@huawei.com