Open
Conversation
Kamoppl
force-pushed
the
kamilg/april_2025_tests_refactors
branch
from
89ba2c6 to
dbf1a66
Compare
Deixx
reviewed
Apr 23, 2025
| cache.reset_counters() | ||
|
|
||
| with TestRun.step(f"Fill exported object with dirty data"): | ||
| with TestRun.step(f"Prepare I/O to fill exported object with dirty data"): |
Contributor
There was a problem hiding this comment.
unnecessary f-string
how is I/O prepared here? (preparing config for I/O tool is not a real test step)
| dirty_4k = cache.get_statistics().usage_stats.dirty.get_value(Unit.Blocks4096) | ||
| fio.verification_with_pattern("0xdeadbeef") | ||
|
|
||
| with TestRun.step("Run fio"): |
Contributor
There was a problem hiding this comment.
I didn't see this step before writing my comment for the previous file ;)
Comment on lines
185
to
199
| with TestRun.step("Prepare I/O to separate disk test file"): | ||
| fio = ( | ||
| Fio() | ||
| .create_command() | ||
| .io_engine(IoEngine.libaio) | ||
| .read_write(ReadWrite.write) | ||
| .block_size(bs) | ||
| .block_size(Size(2, Unit.MebiByte)) | ||
| .direct() | ||
| .io_depth(256) | ||
| .target(core) | ||
| .size(file_size) | ||
| ) | ||
| fio.default_run_time = timedelta(hours=4) # timeout for non-time-based fio | ||
|
|
||
| with TestRun.step("Run I/O"): |
| core_disk = TestRun.disks["core"] | ||
|
|
||
| cache_disk.create_partitions([Size(100, Unit.MebiByte)]) | ||
| core_disk.create_partitions([Size(5, Unit.GibiByte)] * 2) |
Contributor
There was a problem hiding this comment.
2 is a small number of partitions in a test the randomises the order of adding them
|
|
||
| for _ in TestRun.iteration(range(0, iterations_number)): | ||
| with TestRun.step("Detach all core devices"): | ||
| for core in cores: |
Contributor
There was a problem hiding this comment.
I think detach order should be also randomized
| """ | ||
| title: Test for triple level cache. | ||
| description: | | ||
| Test if cache can be used as core of other cache up to three levels |
Contributor
There was a problem hiding this comment.
this is incorrect - cache can never be used as a core
Comment on lines
66
to
70
| with TestRun.step("Create file on exported object"): | ||
| md5_sums = create_files_with_md5sums(mount_point, 100) | ||
|
|
||
| with TestRun.step("Check md5 sums between original file and exported object"): | ||
| compare_md5sums(md5_sums, mount_point, copy_to_tmp=True) |
Contributor
There was a problem hiding this comment.
confusing steps - if you create the file on the exported object, then if is the original file, so the last step implies comparing the test file to itself ;)
katlapinka
reviewed
Apr 23, 2025
added 5 commits
September 30, 2025 17:21
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
…hronous read of the device Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
Kamoppl
force-pushed
the
kamilg/april_2025_tests_refactors
branch
from
dbd184f to
237e25d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.