Open
Conversation
arutk
reviewed
Feb 26, 2021
test/functional/tests/fault_injection/test_error_device_as_cache.py
Outdated
Show resolved
Hide resolved
Add missing `f` to **strings** that should be **f-strings**. Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
while error device is used as cache device Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
e0c97c6 to
17ccb0f
Compare
|
retest this please |
|
Can one of the admins verify this patch? |
Deixx
reviewed
Sep 3, 2024
Contributor
Deixx
left a comment
There was a problem hiding this comment.
commit minor fixes in tests can be dropped
otherwise looks ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs https://github.com/Open-CAS/test-framework/pull/240