Conversation
matrss
reviewed
Jan 13, 2025
mslib/msui/flighttrack.py
Outdated
| import fs | ||
| import xml.dom.minidom | ||
| import xml.parsers.expat | ||
| import xml.dom.minidom # nosec |
Collaborator
There was a problem hiding this comment.
I don't like that the nosec marker is on the import, instead of on the actual usage that was deemed unproblematic. This would disable warnings for new places using the module, if any were to be added in the future. Is it possible to instead mark every line using xml.dom.minidom as nosec instead, with an explanation why they are safe?
Member
Author
There was a problem hiding this comment.
explanation moved. At the moment we add a sec scanner we maybe have to configure that differently.
joernu76
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #542
some more to replace