Conversation
| parser.add_argument("--logfile", help="If set to a name log output goes to that file", dest="logfile", | ||
| default=None) | ||
| parser.add_argument("-s", "--seed", help="creates demodata for the mswms server", | ||
| action="store_true", default=False) |
There was a problem hiding this comment.
and what does this?
Have you tried the examples?
There was a problem hiding this comment.
and what does this?
Have you tried the examples?
It adds an argument '-s' or '--seed' to enable data seeding using the mswms command.
There was a problem hiding this comment.
and how is the method called?
Does it create demodata in a dir as the description says?
There was a problem hiding this comment.
no it is not creating
There was a problem hiding this comment.
can u give some hint where to do the changes?
There was a problem hiding this comment.
look in conftest for an example, this creates also demodata for the tests.
There was a problem hiding this comment.
hi i have added the seed function. Can u jst review it?
|
@anj20 do you have time to finish this in the next days? |
|
@anj20 |
| server_config_fs=fs.open_fs("~/mss")) | ||
| examples.create_server_config(detailed_information=True) | ||
| examples.create_data() | ||
| print("\nTo use this setup you need the mswms_settings.py in your python path e.g. \nexport PYTHONPATH=~/mss") |
There was a problem hiding this comment.
when this is now copied here and we won´t call mswms_demodata any more the main function of demodata can be removed.
setup.py needs changes
and the docs need changes too
There was a problem hiding this comment.
ok lemme make the changes
There was a problem hiding this comment.
hi do i need to remove the entire main funtion?
There was a problem hiding this comment.
there should not be more copy/paste duplicated code.
updated plz review it |
|
this likly needs a rebase to develop |
ReimarBauer
left a comment
ReimarBauer
left a comment
There was a problem hiding this comment.
see comments, remove commented off old lines.
|
|
||
| pixi global update mss | ||
|
|
||
|
|
There was a problem hiding this comment.
That is not part of the issue
| @@ -44,7 +44,6 @@ and don't need server configurations. | |||
| ##### Updating | |||
| pixi global update mss | |||
|
|
|||
| We are very grateful for your continuing support for MSS! | ||
|
|
||
| See our [Contributors page](https://mss.readthedocs.io/en/stable/authors.html) for a list of authors. See also our info on [funding]( | ||
| https://mss.readthedocs.io/en/stable/funding.html). No newline at end of file |
There was a problem hiding this comment.
what is wrong with the line and how it is related to the task?
| server_config_fs=fs.open_fs("~/mss")) | ||
| examples.create_server_config(detailed_information=True) | ||
| examples.create_data() | ||
| print("\nTo use this setup you need the mswms_settings.py in your python path e.g. \nexport PYTHONPATH=~/mss") |
There was a problem hiding this comment.
there should not be more copy/paste duplicated code.
2 participants
Purpose of PR?: Replace the mswms_demodata command with a --seed option for the mswms command, aligning it with the behavior of the seed option in mscolab
Fixes #2631
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Verified that the seed function runs correctly when executed using mswms -seed
Checklist:
<type>: <subject>