Skip to content

refactor: Extract MSColab dialogs to separate modules#2993

Open
Sumit6307 wants to merge 1 commit intoOpen-MSS:developfrom
Sumit6307:refactor/mscolab-ui-separation
Open

refactor: Extract MSColab dialogs to separate modules#2993
Sumit6307 wants to merge 1 commit intoOpen-MSS:developfrom
Sumit6307:refactor/mscolab-ui-separation

Conversation

@Sumit6307
Copy link

@Sumit6307 Sumit6307 commented Feb 5, 2026

Purpose of PR?:
This PR refactors mslib/msui/mscolab.py to address the "God Class" maintainability issue. It extracts the MSColab_ConnectDialog and MSColab_OperationArchiveBrowser classes into their own dedicated modules (mslib/msui/mscolab_connect_dialog.py and mslib/msui/mscolab_archive_browser.py). This separation significantly reduces the size of mscolab.py and improves code organization without changing functionality.

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::

  • Verified syntax correctness of new modules using python -m py_compile.
  • Verified that mslib/msui/mscolab.py correctly imports and initializes the extracted classes.
  • Confirmed that the refactoring preserves the original class signatures and inheritance.

Additional information for reviewer? :
This is part of a larger effort to improve the modularity of the MSColab client. By isolating UI components, we pave the way for better testability and future separation of network logic.

Does this PR results in some Documentation changes?
No

Checklist:

  • Bug fix. Fixes #
  • New feature (Non-API breaking changes that adds functionality)
  • PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

@Sumit6307
Copy link
Author

Hi @ReimarBauer , please have a look at this PR. Thanks!


This file is part of MSS.

:copyright: Copyright 2019-2024 by the MSS team, see AUTHORS.
Copy link
Member

@ReimarBauer ReimarBauer Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adjust the year to -2026


This file is part of MSS.

:copyright: Copyright 2019-2024 by the MSS team, see AUTHORS.
Copy link
Member

@ReimarBauer ReimarBauer Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adjust the year to -2026

@ReimarBauer
Copy link
Member

We usually describe a task or project within an issue in our project, and then discuss it there. Once it's been assigned, we start working on it.

I noticed you were interested in Google Summer of Code (GSoC). We won’t be taking part this year.

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments and result of linting tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants