emulator: Don’t require config.h #437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37d7d51 (2021-07-22) made it so that config.h was only required if necessary to override config_defaults.h, and ae52505 (2022-10-19) documented that. However, the emulator build still required the presence of config.h. This updates remaining files to `#include "config_defaults.h"`, which has the responsibility for conditionally further including "config.h" if present, just like the non-emulator build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
37d7d51 (2021-07-22) made it so that
config.hwas only required if necessary to overrideconfig_defaults.h, and ae52505 (2022-10-19) documented that. However, the emulator build still required the presence ofconfig.h. This updates remaining files to#include "config_defaults.h", which has the responsibility for conditionally further includingconfig.hif present, just like the non-emulator build.