Replace the jackson-base parent with a single self contained pom#98
Open
nrayburn-tech wants to merge 1 commit intoOpenAPITools:0.3.xfrom
Open
Replace the jackson-base parent with a single self contained pom#98nrayburn-tech wants to merge 1 commit intoOpenAPITools:0.3.xfrom
nrayburn-tech wants to merge 1 commit intoOpenAPITools:0.3.xfrom
Conversation
The jackson-base parent pom is only really intended for Jackson projects, so this puts the jackson-databind-nullable project in a better position to not inherit parent changes that may be undesirable.
nrayburn-tech
commented
Nov 2, 2025
|
|
||
| <maven.build.timestamp.format>yyyy-MM-dd HH:mm:ssZ</maven.build.timestamp.format> | ||
| <!-- TODO: Update on build. Used for reproducible builds. --> | ||
| <project.build.outputTimestamp>2025-10-30T23:03:53Z</project.build.outputTimestamp> |
Contributor
Author
There was a problem hiding this comment.
Currently the project just inherits the value from the parent pom, but this value should be updated when builds happen.
So what I have here matches existing behavior, but the existing behavior isn't really right.
Contributor
Author
|
@wing328 I’m not sure if there’s any way to make this change easier to review. It is targeting the 0.3 branch, so anything that is broken will only be part of the new version with Jackson 3 support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jackson-base parent pom is only really intended for Jackson projects, so this puts the jackson-databind-nullable project in a better position to not inherit parent changes that may be undesirable.
This should be safe to do in 0.2.x, but it wouldn't hurt to wait until 0.3.x with some other breaking changes such as Jackson 3 support.Switched this to just target 0.3.x and play it safe.
There are a few before/after changes, but I'm not sure there's anything that's relevant.
8instead of1.8forX-Compile-Source-JDKandX-Compile-Target-JDK.sitegoal for anything that I'm aware of.mvn verifybefore/after, and a diff of the output to the console before/after and the above is all I found that was relevant and changed.Relevant parent pom file links.
https://repo1.maven.org/maven2/com/fasterxml/jackson/jackson-base/2.20.1/jackson-base-2.20.1.pom
https://repo1.maven.org/maven2/com/fasterxml/jackson/jackson-bom/2.20.1/jackson-bom-2.20.1.pom
https://repo1.maven.org/maven2/com/fasterxml/jackson/jackson-parent/2.20/jackson-parent-2.20.pom
https://repo1.maven.org/maven2/com/fasterxml/oss-parent/70/oss-parent-70.pom