Conversation
|
https://github.com/OpenAPITools/openapi-generator/actions/runs/16865113770/job/47794205903?pr=21724 you can search for toLowerCase in the project and see how other generators call this function to address the build failure |
rajvesh
force-pushed
the
httplib-server-codegen
branch
2 times, most recently
from
474d239 to
145b0b3
Compare
|
Hello @wing328 , |
|
still failed can you try building the project locally to confirm the fix? |
rajvesh
force-pushed
the
httplib-server-codegen
branch
from
145b0b3 to
d220c6e
Compare
|
I am building with this command.It is passing build locally. |
|
please try |
rajvesh
force-pushed
the
httplib-server-codegen
branch
from
3234b2f to
10f300d
Compare
|
please review the build errors when you've time: https://github.com/OpenAPITools/openapi-generator/actions/runs/17289476813/job/49073762692?pr=21724 |
With the above command , I am facing errors for maven plugin: [INFO] openapi-generator-project .......................... SUCCESS [ 2.191 s] |
works for me without errors can you merge the latest master into your branch? |
Supports: All OpenAPI 3.x data types: primitives, arrays, enums, nullable/optional fields, nested objects All parameter types: path, query, header, cookie, and combinations Schema composition: allOf (inheritance), oneOf (discriminated unions), anyOf (flexible unions) Security schemes: API key and bearer token authentication Discriminator-based polymorphic deserialization and error handling Provides: Error handling for invalid JSON, type mismatches, missing/unknown discriminator, and parameter validation Build system integration (CMake) for easy compilation and linking with required dependencies Clear build and run instructions for local development and testing Enables comprehensive, real-world validation of generated C++ server code against OpenAPI specifications
rajvesh
force-pushed
the
httplib-server-codegen
branch
from
10f300d to
5fa32aa
Compare
|
Hello @wing328 , |
|
Looks like , The CI/CD errors (such as "Null key for a Map not allowed in JSON" and missing schema warnings) are not related to my changes. I have only modified files relevant to the cpp-httplib-server improvements. The errors originate from test specifications or example files within the OpenAPI Generator test suite, not from my OpenAPI spec or any files I changed. My modifications do not introduce these issues. This is my analysis of these checks failed. In my local, builds for codegen, tests, and sample code builds are successfull. |
| restore-keys: ${{ runner.os }}-m2 | ||
| - name: Build OpenAPI Generator | ||
| run: ./mvnw clean package -DskipTests -pl modules/openapi-generator-cli -am | ||
| - name: Run unit tests for CppHttplibServerCodegen |
There was a problem hiding this comment.
suggestion: i don't we need to run these CppHttpLibserver tests in this workflow as it's already covered by mvn clean install in the main workflow.
|
I'm able to repeat the issue locally. I'll take another look to see what I can do to resolve it Is it correct to say that you've tested with the auto-generated output (C++ server-side code) and it works fine for you? |
2 participants
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)