Java-wiremock: Correctly handle multiple MIME-types in HTTP-Accept-headers #22133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of an endpoint that may reply with multiple Content-Types (e.g. a file as application/octet-stream if successful and an error message as application/json in case of an error), the Wiremock stubs create the following snippet:
This results in a failed request if there are not at least to "Accept: "-headers, one being exactly
Accept: application/octet-stream, the other being exactlyAccept: application/json. This, however, is not how user agents set the "Accept: "-Header. Instead, they supply only one Header containing both (separated by,plus optional whitespace).This PR replaces the lines like
with one line for each requested header like this:
The switch from
havingExactlytocontainingis due to shortcomings in the wiremock DSL, which would require specification-compliant parsing of the "Accept: "-Header content. I don't think that would be worth the trouble, though, since substring matching ought to be enough for test suites.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@bbdouglas
@sreeshas
@jfiala
@lukoyanov
@cbornet
@jeff9finger
@karismann
@Zomzog
@lwlee2608
@martin-mfg